983080 - [MADAI][Settings] @2.25x assets update for Settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Helen Huang [:HHuang]]

Attachment: [e-mail]

Comment 1

[Helen Huang [:HHuang]]

Attachment: [e-mail]

Update the latest images

Comment 2

[Helen Huang [:HHuang]]

Hi Arthur,
We would like to update 2.25x assets for Madai, could you help?

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/17640

Evelyn, could you help review this? Simply adds 2.25x assets. The assets have also been recompressed by the tool.

Comment 4

[Evelyn Hung]

Comment on attachment 8397530 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/17640

No sure if assets update needs a review, but thanks!

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: c7b8e7f956838668d19cb34a99ac2b4f2998e79a

Comment 6

[Gabriele Svelto [:gsvelto] (PTO)]

I'm a bit perplexed as I've noticed that the PR has deleted the apps/settings/style/images/[e-mail] file. Is this correct?

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

No, it's a mistake. Thanks for catching this.

revert: d04072d9f8bb4ae8bac0f637eaa0df6d6a457dfb

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: f2fe740b7f4048c982d9ab60d715cc5a41d074ba

Comment 9

[Gabriele Svelto [:gsvelto] (PTO)]

(In reply to Arthur Chen [:arthurcc] from comment #7)
> No, it's a mistake. Thanks for catching this.

You're welcome, I was lucky to notice it while rebasing bug 989357.