Closed Bug 983193 Opened 12 years ago Closed 12 years ago

ui/button: passing a button into button.state() is broken in master

Categories

(Add-on SDK Graveyard :: General, defect, P1)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: wbamberg, Assigned: zer0)

Details

Attachments

(1 file)

PR 1431
46 bytes, text/x-github-pull-request
irakli
: review+
Details | Review
Here's a gist: https://gist.github.com/wbamberg/9521562. This example works in Nightly (2014-03-11) but does not work in the laster master.
Assignee: nobody → zer0
Attached file PR 1431 —
Attachment #8390600 - Flags: review?(rFobic)
Attachment #8390600 - Flags: review?(rFobic) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/a46cfbb4be9bb1e0f2879e2f5381bbe838f0219a Bug 983193 - ui/button: passing a button into button.state() is broken in master - Fixed regression - Added tests https://github.com/mozilla/addon-sdk/commit/3ebcca4166df14ccdb1e681cfb50a05fcada4abd Merge pull request #1431 from ZER0/button-state/983193 fix Bug 983193 - ui/button: passing a button into button.state() is broken in master r=@gozala
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: