Closed
Bug 98332
Opened 24 years ago
Closed 24 years ago
Warnings still IRK me
Categories
(NSS :: Libraries, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
3.4
People
(Reporter: timeless, Assigned: rrelyea)
Details
Attachments
(2 files)
|
8.62 KB,
text/html
|
Details | |
|
2.45 KB,
patch
|
Details | Diff | Splinter Review |
ok, i split Bugzilla Bug 99419 for loop executes only once -- CODE ERROR? off.
would someone please review the remainder of the patch and commit it?
Assignee: wtc → kai.engert
whoops kaie is psm only, i had selected him based on brendan's advice.
Assignee: kai.engert → lord
|
||
Comment 5•24 years ago
|
||
Assigned the bug to Bob.
Note that these warnings are from the tip, which is
work in progress.
Here is my review of the patch.
constants.c: I don't know whether the patch is right.
secvfy.c: It is not necessary to remove that "not reached"
assertion.
pk11util.c: The patch is correct. The "return" should be
removed.
pkcs11c.c: The patch is wrong. 'key_type' should be
initialized to -1. We can add a (CK_KEY_TYPE) cast
in front of -1 to get rid of the compiler warning.
Assignee: lord → relyea
Priority: -- → P2
Target Milestone: --- → 3.4
Version: 4.0 → 3.4
|
Assignee | |
Comment 6•24 years ago
|
||
These warnings should be fixed on the current tip.
bob
|
|
||
Comment 7•24 years ago
|
||
Changed the QA contact to Bishakha.
QA Contact: sonja.mirtitsch → bishakhabanerjee
|
|
Assignee | |
Comment 8•24 years ago
|
||
close the bug as per my comments of about three months ago
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•