Warnings still IRK me

RESOLVED FIXED in 3.4

Status

NSS
Libraries
P2
normal
RESOLVED FIXED
17 years ago
16 years ago

People

(Reporter: timeless, Assigned: Robert Relyea)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
 
(Reporter)

Comment 1

17 years ago
Created attachment 48273 [details]
recent solaris warnings
(Reporter)

Comment 2

17 years ago
Created attachment 48274 [details] [diff] [review]
changes
(Reporter)

Comment 3

17 years ago
ok, i split Bugzilla Bug 99419 for loop executes only once -- CODE ERROR? off.
would someone please review the remainder of the patch and commit it?
Assignee: wtc → kai.engert
(Reporter)

Comment 4

17 years ago
whoops kaie is psm only, i had selected him based on brendan's advice.
Assignee: kai.engert → lord

Comment 5

17 years ago
Assigned the bug to Bob.

Note that these warnings are from the tip, which is
work in progress.

Here is my review of the patch.

constants.c: I don't know whether the patch is right.
secvfy.c: It is not necessary to remove that "not reached"
    assertion.
pk11util.c: The patch is correct.  The "return" should be
    removed.
pkcs11c.c: The patch is wrong.  'key_type' should be
    initialized to -1.  We can add a (CK_KEY_TYPE) cast
    in front of -1 to get rid of the compiler warning.
Assignee: lord → relyea
Priority: -- → P2
Target Milestone: --- → 3.4
Version: 4.0 → 3.4
(Assignee)

Comment 6

16 years ago
These warnings should be fixed on the current tip. 

bob

Comment 7

16 years ago
Changed the QA contact to Bishakha.
QA Contact: sonja.mirtitsch → bishakhabanerjee
(Assignee)

Comment 8

16 years ago
close the bug as per my comments of about three months ago
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.