Closed Bug 983460 Opened 6 years ago Closed 6 years ago

Opcodes.h has extra TMPSLOT for JSOP_SETPROP

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: efaust, Assigned: efaust)

Details

(Whiteboard: [js:t])

Attachments

(1 file)

Back when I was an intern, I made a mistake: I changed jsopcode.tbl to add a slot only necessary for Ion. But we don't need to do that anymore, as the codepath that deals with that has been fixed.
Attachment #8390891 - Flags: review?(jwalden+bmo)
Comment on attachment 8390891 [details] [diff] [review]
Right an old wrong

Review of attachment 8390891 [details] [diff] [review]:
-----------------------------------------------------------------

Not being familiar with the original Ion use, I'm not sure I'm competent to review this.  Forwarding.
Attachment #8390891 - Flags: review?(jwalden+bmo) → review?(jdemooij)
Attachment #8390891 - Flags: review?(jdemooij) → review+
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/351382fc8e1f since I didn't have any guess about which of your patches (if either) would have caused the https://tbpl.mozilla.org/php/getParsedLog.php?id=37794837&tree=Mozilla-Inbound assertion.
https://hg.mozilla.org/integration/mozilla-inbound/rev/23c6b9e2fab3

Relanded after finding and fixing the problem with the other patch in the original push.
https://hg.mozilla.org/mozilla-central/rev/23c6b9e2fab3
Assignee: nobody → efaustbmo
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.