983480 - [B2G][Contacts][Favorite] Unable to favorite then unfavorite (or vice versa) a Facebook contact

Status: RESOLVED DUPLICATE of bug 983777

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[gbennett]

Description:
This behavior only occurs if you stay within the contacts details page. Once you back out and go back in you will be able to trigger the favorite button again (still only once). 

After a user favorites a Facebook contact they will be unable to remove as favorite (the favorite star doesn't go away), and vice versa if a contact is removed as favorite they can't be refavorited.

Repro Steps:
1) Update a Buri to BuildID: 20140312040203
2) Open Contacts app
3) Go to Settings and import Facebook contacts
4) Select and favorite a contact
5) Try to remove as favorite

Actual:
Favorite star stays and user is still favorited.

Expected:
Star is removed and contact is no longer favorited.

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140312040203
Gaia: 3005269d4dcabcc7d27eaf72bda44a969873af8c
Gecko: 23005b395ae8
Version: 30.0a1
Firmware Version: v1.2-device.cfg

This does repro on Buri 1.3:
Device: Buri v1.3 Moz Ril
Build ID: 20140313004002
Gecko: https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/9368fd13bfa6
Gaia: 6194def5ceed3f4b9bc9de0ea2c11661cd439a27
Platform Version: 28.0
Firmware Version: v1.2-device.cfg

This does not repro on latest Buri 1.2 or 1.1

Repro frequency: 3/3, 100%
See attached: https://www.youtube.com/watch?v=T7BCI__BiVc

Comment 1

[Jason Smith [:jsmith]]

Actually wait a second - can we get a video here that follows the STR exactly? The video here is showing multiple switches, which is different than the STR shown in the bug.

Also - what happens if I favorite the contact, kill the contacts app, and unfavorite it later?

Comment 2

[Jose Manuel Cantera]

cannot repro it

Comment 3

[Cody Roesch [:croesch]]

http://youtu.be/BZ_7Ufn1stQ
Video added for the repro steps shown in comment 0 per jason's request. (Contacts were previously imported and not shown in the video to save time.)

The original bug here is that when you are inside an imported contact from facebook, if the user taps on the Add as Favorite button, a star appears in the header next to the contact name as expected. However when the user taps on the Remove as Favorite button, the star in the header remains and indicates the user is still a favorite which is incorrect. This was the main issue Garrett described to me.

To answer the second part of your question jason, the user can back out of the contact details page and then go back into the contact details page and remove the star icon with the Remove as Favorites button. However they will not be able to reapply the star simply by adding as Favorite again. They will have to back out again and go back in to do it.

Comment 4

[Jason Smith [:jsmith]]

Minor regression.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

It's the same problem with saving a facebook contact that we had with bug 983777. Now this one is fixed, so marking as duplicate since the fix is valid for this one.