983508 - [Build System] install-test-media get wrong "Pictures" path

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

$ make install-test-media
adb push test_media/DCIM /sdcard/DCIM
cannot stat 'test_media/DCIM': No such file or directory
make: *** [install-test-media] Error 1

Actually all pictures are under test_media/Pictures in gaia code base.

https://github.com/mozilla-b2g/gaia/tree/master/test_media/Pictures

Comment 1

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/17180

Hi Yuren, 
   please help to review this patch, thanks.

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8391005 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/17180

Gary, could you verify the content of output file to check what command are you executed?

Comment 3

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Comment on attachment 8391005 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/17180

Hi Yuren,
I've addressed your comment, please review it again.
Thanks.

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8391005 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/17180

thanks. fake-adb may not useful for this case but it would be useful if we have install-gaia integration test.

Comment 5

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

travis green:
https://travis-ci.org/mozilla-b2g/gaia/builds/20756761

land in gaia master:
https://github.com/mpizza/gaia/commit/3702cdccb382a99ef590a183a1ede6fea4f4e558