983538 - Start converting MFBT to standard Mozilla style

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Nicholas Nethercote [inactive]]

MFBT should use standard Mozilla style.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1a) - Convert mfbt/SplayTree.h to Mozilla style.

This just changes indentation; |hg qdiff -w| was empty. I'll merge this with
the following patch before landing.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 1b) - Convert mfbt/SplayTree.h to Mozilla style.

All the non-indentation changes.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Remove a dead field in SplayTree.

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Update mfbt/STYLE.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8391030 [details] [diff] [review]
(part 2) - Remove a dead field in SplayTree.

Done in bug 986023.

Comment 6

[Nicholas Nethercote [inactive]]

Review ping.

Comment 7

[Nicholas Nethercote [inactive]]

Comment on attachment 8391026 [details] [diff] [review]
(part 1a) - Convert mfbt/SplayTree.h to Mozilla style.

Review of attachment 8391026 [details] [diff] [review]:
-----------------------------------------------------------------

Waldo says froydnj can review here too. Hooray!

Comment 8

[Nathan Froyd [:froydnj]]

Comment on attachment 8391028 [details] [diff] [review]
(part 1b) - Convert mfbt/SplayTree.h to Mozilla style.

Review of attachment 8391028 [details] [diff] [review]:
-----------------------------------------------------------------

::: mfbt/SplayTree.h
@@ +68,3 @@
>    }
>  
> +  T* find(const T& aV)

Gecko style tends to go for verbosity in function arguments...maybe aValue here and in other member functions?

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8b52179e47ee
https://hg.mozilla.org/mozilla-central/rev/677d12a5d608