983564 - [Gaia] [Build] reduce |make| time

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

Find ways to reduce the time for |make|.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

When execute |time make|, here's the result as below.

real	0m44.264s
user	0m34.328s
sys	0m8.281s

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

After this patch
real	0m29.489s
user	0m20.891s
sys	0m6.552s

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

We've called utils.getGaia too many times in webapp-zip.js and webapp-manifest.js , I suggest we can cache the data inside utils.js. And we'll also refactor these two scripts later.

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8391087 [details] [review]
PR to master

Hi Yuren,
I believe this simple patch can reduce the |make| consuming time.
Please kindly check. Thanks.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8391087 [details] [review]
PR to master

George, could you use sinleton pattern for it?

we can use utils.gaia.getInstance() to get it and you can keep the instance in utils.gaia.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8391087 [details] [review]
PR to master

Hi Yuren,
patch is updated,
please kindly check, thanks.

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8391087 [details] [review]
PR to master

r=yurenju if this.data is changed to this.instance, thank you!

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

push to tbpl
https://tbpl.mozilla.org/?tree=Try&rev=d961a2f2bfb8

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Merge into master,
https://github.com/mozilla-b2g/gaia/commit/a04f630e0a2bf382c9afe21784e357238434b32c