983583 - [Australis] Customizable items labels sometimes wrap following hyphenation rules of different language if language packs installed

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Aurora 	20140313004000 on Windows 8.1 Pro

After installing a German language pack and setting general.useragent.locale to de and closing and launching Aurora again, the menu items of the Australis menu have German labels, but are wrapped following English rules, e.g.

"Seit speich-
ern"

should be

"Seite spei-
chern"

PanelUI-contents is still en-US

Comment 1

[:Gijs (he/him)]

So I totally messed up dealing with review comments when landing this part of bug 944947. Excellent! :-\

Comment 2

[:Gijs (he/him)]

Attachment: define missing PREF_SELECTED_LOCALE,

Comment 3

[:Gijs (he/him)]

Théo, this might be affecting some of the issues you had with the French l10n for the panel :-|

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 8391126 [details] [diff] [review]
define missing PREF_SELECTED_LOCALE,

Review of attachment 8391126 [details] [diff] [review]:
-----------------------------------------------------------------

I am no peer, so I can only grant feedback+.

Comment 5

[:Gijs (he/him)]

(In reply to Archaeopteryx [:aryx] from comment #4)
> Comment on attachment 8391126 [details] [diff] [review]
> define missing PREF_SELECTED_LOCALE,
> 
> Review of attachment 8391126 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I am no peer, so I can only grant feedback+.

Works for me! :-)

remote:   https://hg.mozilla.org/integration/fx-team/rev/6f44869ee62c

Comment 6

[:Gijs (he/him)]

Comment on attachment 8391126 [details] [diff] [review]
define missing PREF_SELECTED_LOCALE,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis / bug 944947
User impact if declined: wrong hyphenation rules followed in non-en-US
Testing completed (on m-c, etc.): was tested correctly in bug 944947, landed broken code instead of tested code - will soon be on m-c
Risk to taking this patch (and alternatives if risky): this will affect l10n, but it *should* be affecting them in a 'good' way, in that their strings get hyphenated correctly instead of the mess that it is now
String or IDL/UUID changes made by this patch: none

Comment 7

[Théo Chevalier]

(In reply to :Gijs Kruitbosch from comment #3)
> Théo, this might be affecting some of the issues you had with the French
> l10n for the panel :-|

If I understand correctly, the issue here is only affecting langpacks, right? I was testing with a French localized build, not a .xpi. So, French hyphenation rules may be the cause?

Comment 8

[:Gijs (he/him)]

(In reply to Théo Chevalier [:tchevalier] from comment #7)
> (In reply to :Gijs Kruitbosch from comment #3)
> > Théo, this might be affecting some of the issues you had with the French
> > l10n for the panel :-|
> 
> If I understand correctly, the issue here is only affecting langpacks,
> right? I was testing with a French localized build, not a .xpi. So, French
> hyphenation rules may be the cause?

No, as far as I can tell the code was just broken. You can verify by inspecting the "PanelUI-contents" element in DOM Inspector in a French build.

Comment 9

[Théo Chevalier]

Attachment: Screenshot (fr build)

Well, just made a French build, "Mar-que-pages" has been fixed, but visually it's worse.
On this screenshot, the only widget that must be hyphenated is "Développement" :\
I don't know if other locales are regressing like French, though.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

That behavior isn't new, see comment 0. But I agree, there should be a logic which tries to put whole words in the lines.

Comment 11

[:Gijs (he/him)]

(In reply to Archaeopteryx [:aryx] from comment #10)
> That behavior isn't new, see comment 0. But I agree, there should be a logic
> which tries to put whole words in the lines.

I don't know that there is a way to do that. This is simple CSS hyphenation. I don't believe we have any more control over it than that, unless we switch to manual hyphenation, which would require a lot of work from localizers.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6f44869ee62c

Comment 13

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/b803b6759158

Comment 14

[Bogdan Maris, Desktop QA]

Can you please verify that this issue is fixed on Firefox 29RC and latest Aurora using french builds?

Comment 15

[Théo Chevalier]

(In reply to Bogdan Maris, QA [:bogdan_maris] from comment #14)
> Can you please verify that this issue is fixed on Firefox 29RC and latest
> Aurora using french builds?

The patch is working as expected on Firefox 29.
Only the "Tabs group" widget have hyphenation that it shouldn't have, but that's my fault on the l10n side. I will fix that for Firefox 30.

Comment 16

[Ada [:adalucinet]]

Theo, could you please verify if this issue is also fixed on Firefox 30 beta 5? Thanks in advance.

Comment 17

[Théo Chevalier]

Thanks for asking Alexandra

Verified on Firefox 30 beta 5, put all the widgets into the menu, hyphenation is working as expected in French, "Tabs group" included.

Comment 18

[Ada [:adalucinet]]

Thank you very much, Theo!
Marking as verified on Fx 30 based on comment 17.