Closed Bug 983609 Opened 6 years ago Closed 6 years ago

Only update toolbar private mode when a new tab is selected

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 30

People

(Reporter: lucasr, Assigned: lucasr)

Details

Attachments

(1 file)

The toolbar's private mode only changes when a new tab is selected.
Attachment #8391146 - Flags: review?(bnicholson)
Comment on attachment 8391146 [details] [diff] [review]
Only update toolbar private mode when a new tab is selected (r=bnicholson)

Review of attachment 8391146 [details] [diff] [review]:
-----------------------------------------------------------------

The tab actually cannot change private state at all after being created, so even SELECTED is overkill. Can this be moved to ADDED?
Attachment #8391146 - Flags: review?(bnicholson) → feedback+
Comment on attachment 8391146 [details] [diff] [review]
Only update toolbar private mode when a new tab is selected (r=bnicholson)

Review of attachment 8391146 [details] [diff] [review]:
-----------------------------------------------------------------

Oh wait -- this is for updating the toolbar, not the tab itself.
Attachment #8391146 - Flags: feedback+ → review+
https://hg.mozilla.org/mozilla-central/rev/447791883dd4
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
You need to log in before you can comment on or make changes to this bug.