Closed Bug 983609 Opened 12 years ago Closed 12 years ago

Only update toolbar private mode when a new tab is selected

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 30

People

(Reporter: lucasr, Assigned: lucasr)

Details

Attachments

(1 file)

Only update toolbar private mode when a new tab is selected (r=bnicholson)
2.10 KB, patch
bnicholson
: review+
Details | Diff | Splinter Review
The toolbar's private mode only changes when a new tab is selected.
Attachment #8391146 - Flags: review?(bnicholson)
Comment on attachment 8391146 [details] [diff] [review] Only update toolbar private mode when a new tab is selected (r=bnicholson) Review of attachment 8391146 [details] [diff] [review]: ----------------------------------------------------------------- The tab actually cannot change private state at all after being created, so even SELECTED is overkill. Can this be moved to ADDED?
Attachment #8391146 - Flags: review?(bnicholson) → feedback+
Comment on attachment 8391146 [details] [diff] [review] Only update toolbar private mode when a new tab is selected (r=bnicholson) Review of attachment 8391146 [details] [diff] [review]: ----------------------------------------------------------------- Oh wait -- this is for updating the toolbar, not the tab itself.
Attachment #8391146 - Flags: feedback+ → review+
https://hg.mozilla.org/mozilla-central/rev/447791883dd4
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: