983636 - Update tests to support testing of adding duplicate properties

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Mihaela Velimiroviciu (:mihaelav)]

Currently, the addNewManifestProperty() test doesn't check if a duplicate property was added, hence having 2 properties with the same key won't be caught.
Moreover, there are some cases when adding two properties  causes the test to fail - 2 properties with the second's name a substring of the first's (e.g. "food" and then "foo")

Comment 1

[Mihaela Velimiroviciu (:mihaelav)]

Attachment: v1

Updated addNewManifestProperty to also check for duplicate properties and added checks for adding properties with the same id in the same parent and in different parents.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8466163 [details] [diff] [review]
v1

Review of attachment 8466163 [details] [diff] [review]:
-----------------------------------------------------------------

This seems fine to me, so we can check-in, assuming a Try run looks good.

However, it's probably not worth expanding the manifest editor's test coverage after this bug because it will soon be removed (bug 1007061) (along with all of App Manager) when WebIDE (its replacement) is enabled by default.

Comment 3

[Mihaela Velimiroviciu (:mihaelav)]

Try run is green: https://tbpl.mozilla.org/?tree=Try&rev=72b91ca2c585

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/934ec57a3184

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/934ec57a3184