Closed Bug 983636 Opened 7 years ago Closed 7 years ago

Update tests to support testing of adding duplicate properties

Categories

(DevTools Graveyard :: WebIDE, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 34

People

(Reporter: mihaelav, Assigned: mihaelav)

Details

Attachments

(1 file)

Currently, the addNewManifestProperty() test doesn't check if a duplicate property was added, hence having 2 properties with the same key won't be caught.
Moreover, there are some cases when adding two properties  causes the test to fail - 2 properties with the second's name a substring of the first's (e.g. "food" and then "foo")
Attached patch v1Splinter Review
Updated addNewManifestProperty to also check for duplicate properties and added checks for adding properties with the same id in the same parent and in different parents.
Attachment #8466163 - Flags: review?(jryans)
Comment on attachment 8466163 [details] [diff] [review]
v1

Review of attachment 8466163 [details] [diff] [review]:
-----------------------------------------------------------------

This seems fine to me, so we can check-in, assuming a Try run looks good.

However, it's probably not worth expanding the manifest editor's test coverage after this bug because it will soon be removed (bug 1007061) (along with all of App Manager) when WebIDE (its replacement) is enabled by default.
Attachment #8466163 - Flags: review?(jryans) → review+
https://hg.mozilla.org/integration/fx-team/rev/934ec57a3184
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/934ec57a3184
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.