983690 - Australis: Zoom widget %label is missing in toolbar

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Alice0775 White]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9b11165db831
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20140314004001

Steps To Reproduce:
1 Move Zoom widget to ToolBar

Actual Results:
Zoom widget %label is missing

Comment 1

[Mike de Boer [:mikedeboer]]

Alice, which toolbar specifically?

Comment 2

[Alice0775 White]

Regression window(aurora)
Good:
https://hg.mozilla.org/releases/mozilla-aurora/rev/ec783a38f231
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20140311063942
Bad:
https://hg.mozilla.org/releases/mozilla-aurora/rev/fd7cb7a420cd
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20140311165811
Pushlog:
http://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?fromchange=ec783a38f231&tochange=fd7cb7a420cd

(In reply to Mike de Boer [:mikedeboer] from comment #1)
> Alice, which toolbar specifically?

It happens on any toolbar(MenuBar, TabBar, Bookmarks ToolBar).

I just open PanelUI, and right click on the Zoom Widget, and Move to Toolbar.

Comment 3

[(parental leave 10/24-mid-February) Jared Wein [:jaws] (please needinfo? me)]

Mike, this is in the navbar, but I only can reproduce it on Aurora. Maybe a patch needs to be uplifted?

Comment 4

[(parental leave 10/24-mid-February) Jared Wein [:jaws] (please needinfo? me)]

I don't see anything though that hasn't been uplifted that would cause this.

Comment 5

[(parental leave 10/24-mid-February) Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

This came from a bad uplift in bug 972286 that forgot to remove a plus (+) character from the beginning of one of the CSS lines.

Comment 6

[:Gijs (he/him)]

Comment on attachment 8391405 [details] [diff] [review]
Patch

Review of attachment 8391405 [details] [diff] [review]:
-----------------------------------------------------------------

rs+a=me, because for serious.

Comment 7

[(parental leave 10/24-mid-February) Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/453af220916e

Comment 8

[Cornel Ionce [:cornel_ionce], Desktop Release QA]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (X11; Linux i686; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0

Verified fixed on Firefox 29 beta 5 (build ID: 20140403132807).