Closed
Bug 983714
Opened 10 years ago
Closed 10 years ago
Fix DynamicToolbar VisibilityTransition flags
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 30
People
(Reporter: bnicholson, Assigned: bnicholson)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.02 KB,
patch
|
lucasr
:
review+
|
Details | Diff | Splinter Review |
We're setting immediate = ANIMATE. Oops.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8391292 -
Flags: review?(lucasr.at.mozilla)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Actually, since we're using an enum, we can check IMMEDIATE directly instead of just inverting the condition.
Attachment #8391292 -
Attachment is obsolete: true
Attachment #8391292 -
Flags: review?(lucasr.at.mozilla)
Attachment #8391294 -
Flags: review?(lucasr.at.mozilla)
|
|
Assignee | |
Updated•10 years ago
|
Summary: Fix DynamicToolbar ANIMATE flag → Fix DynamicToolbar VisibilityTransition flags
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8391294 [details] [diff] [review] Fix DynamicToolbar VisibilityTransition flags Review of attachment 8391294 [details] [diff] [review]: ----------------------------------------------------------------- Oopsie.
Attachment #8391294 -
Flags: review?(lucasr.at.mozilla) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d234b1080a13
https://hg.mozilla.org/mozilla-central/rev/d234b1080a13
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•