Closed
Bug 983715
Opened 11 years ago
Closed 11 years ago
Make findAlarms Asynchronous
Categories
(Calendar :: Internal Components, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.2
People
(Reporter: anderson, Assigned: anderson)
References
Details
Attachments
(1 file)
|
5.08 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20140218140359
Actual results:
Replace a for each loop with the asynchronous cal.forEach, and use promises to ensure everything is still executed in the correct order.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8391297 -
Flags: review?(philipp)
|
||
Updated•11 years ago
|
Assignee: nobody → anderson
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8391297 [details] [diff] [review]
Async.patch
Review of attachment 8391297 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, r=philipp. Thanks for the patch!
Attachment #8391297 -
Flags: review?(philipp) → review+
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8391297 [details] [diff] [review]
Async.patch
Review of attachment 8391297 [details] [diff] [review]:
-----------------------------------------------------------------
One minor nit, plus 2 whitespace changes. Nothing important though, I've fixed this before checkin:
::: calendar/base/src/calAlarmService.js
@@ +526,5 @@
> aStatus,
> aOperationType,
> aId,
> aDetail) {
> + let promise = this.addRemovePromise.promise.then((aValue) => {
I removed the unused variable here
|
|
||
Comment 4•11 years ago
|
||
Pushed to comm-central changeset 956d8a7b71e8
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.2
You need to log in
before you can comment on or make changes to this bug.
Description
•