983715 - Make findAlarms Asynchronous

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Reid Anderson]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20140218140359



Actual results:

Replace a for each loop with the asynchronous cal.forEach, and use promises to ensure everything is still executed in the correct order.

Comment 1

[Reid Anderson]

Attachment: Async.patch

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8391297 [details] [diff] [review]
Async.patch

Review of attachment 8391297 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=philipp. Thanks for the patch!

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8391297 [details] [diff] [review]
Async.patch

Review of attachment 8391297 [details] [diff] [review]:
-----------------------------------------------------------------

One minor nit, plus 2 whitespace changes. Nothing important though, I've fixed this before checkin:

::: calendar/base/src/calAlarmService.js
@@ +526,5 @@
>                                                                       aStatus,
>                                                                       aOperationType,
>                                                                       aId,
>                                                                       aDetail) {
> +                let promise = this.addRemovePromise.promise.then((aValue) => {

I removed the unused variable here

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset 956d8a7b71e8