[mozmill] fix calendar recurrenceRotated tests

RESOLVED WONTFIX

Status

Calendar
General
P2
major
RESOLVED WONTFIX
4 years ago
3 months ago

People

(Reporter: Taraman, Assigned: Taraman)

Tracking

(Blocks: 1 bug)

Details

(Assignee)

Description

4 years ago
The tests for recurrences in the rotated views do not pass at the moment.
(Assignee)

Comment 1

4 years ago
Some of the tests test all views as the normal recurrence-tests do.
In my opinion for the rotated tests this makes no sense, because multiweek and month views are not rotated. I believe these parts were copied from the normal recurrence tests.

I would take the tests of these two views out here.
Flags: needinfo?(philipp)
Flags: needinfo?(gasell+mozilla)
Sounds good.
Flags: needinfo?(philipp)
Flags: needinfo?(gasell+mozilla)
(Assignee)

Comment 3

6 months ago
After having seen that the code of the rotated tests is exactly the same as the normal recurrence tests:
Do we really need to check all the recurrences in rotated mode?

Wouldn't it be better to check the rotated view in the view-tests in a single test instead of running all the recurrences through this?
Flags: needinfo?(philipp)
(Assignee)

Comment 4

3 months ago
After talking with Philipp, we decided to drop these tests and create a new test to test the rotated views independent of the recurrences. -> Bug 1365262

I keep the old tests in the repository for a while in case someone has valid objections
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Flags: needinfo?(philipp)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.