Closed
Bug 983795
Opened 10 years ago
Closed 10 years ago
Element#scriptWith should accept extra arguments
Categories
(Testing Graveyard :: JSMarionette, defect)
Testing Graveyard
JSMarionette
Tracking
(Not tracked)
RESOLVED
FIXED
1.4 S3 (14mar)
People
(Reporter: mmedeiros, Assigned: mmedeiros)
Details
(Whiteboard: [p=2])
Attachments
(1 file)
I've found myself needing to pass extra arguments to `Element#scriptWith` but right now that isn't possible. Will need to do some argument "juggling" to make sure old behavior remains intact (passing callback as second argument). This will probably simplify tests and avoid errors (since it will match the `client.executeScript` behavior) - I had to double check documentation and source code to confirm what I was doing wrong.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mmedeiros
Whiteboard: [p=2]
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8391468 -
Flags: review?(gaye)
Comment 2•10 years ago
|
||
Comment on attachment 8391468 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/marionette-js-client/pull/98 Nice!
Attachment #8391468 -
Flags: review?(gaye) → review+
Comment 3•10 years ago
|
||
https://github.com/mozilla-b2g/marionette-js-client/commit/7d3d72475a6729ae38c17e92a11fa4e0403e4832
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → 1.4 S3 (14mar)
Updated•6 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•