Incorrect and incompatible older version selected by AMO

NEW
Unassigned

Status

defect
5 years ago
3 years ago

People

(Reporter: alexander, Unassigned)

Tracking

unspecified
2015-08

Details

(Whiteboard: [ReviewTeam:P1])

Reporter

Description

5 years ago
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20140218135856

Steps to reproduce:

Visit the following add-on page with Firefox 27:

https://addons.mozilla.org/en-US/firefox/addon/cookie-whitelist-with-buttons/

Click on "Add to Firefox".


Actual results:

The "Add to Firefox" button links to version 1.0.3 of the add-on, which Firefox 27 downloads and then refuses to install ("it is not compatible").


Expected results:

AMO should have linked to version 2.2.1, which is the latest version of the add-on compatible with Firefox 27.
Assignee: nobody → kmaglione+bmo
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [ReviewTeam:P1]
Duplicate of this bug: 1052065

Comment 2

5 years ago
The bug I filed is similar but slightly different - in my case, the user is presented with a *newer* version selected by AMO which is incompatible.

As such, if it's being combined with this bug, the title of this bug should read: "Incorrect and incompatible version selected by AMO"
Duplicate of this bug: 1005463
Duplicate of this bug: 1159193
As found out in the now dup bug 1159193

This seems to be a problem in the javascript (or backend python) that causes incorrect css hiding of the primary (seemingly Firefox 4+ or assumed always compatible primary install shell button) and showing of the backup-button (install shell button for firefox 3.6 and older or button that is not always assumed compatible).

When the reported client version determined by the Firefox version user agent slice is outside the latest version compatibility range some add-ons will show an ancient version (normally last one for Firefox 3.5 or 3.6 by hiding one button and unhiding the other. This does not affect every extension on AMO but does affect some notable ones such as Adblock Plus.
This bug is over a year old now.. And the problems have gotten worse.. Is there going to be any progress?

Comment 7

4 years ago
For reference, https://github.com/mozilla/olympia/blob/master/static/js/zamboni/buttons.js will show the first install button it considers compatible. In this case the latest version isn't compatible so the second install button is made visible. AMO's HTML code doesn't have install buttons for all extension versions however (would bloat the page size immensely) - currently it's only "latest" and "latest before extension was made restartless." This makes little sense now that there are virtually no applications without support for restartless extensions around.
I'd been planning to do this in one step, removing the incorrect "backup" version code and adding fallback compatible version detection at the same time. But the second part is surprisingly difficult the way our code is currently structured, so I think I'll just remove the broken backup version code first.
Status: NEW → ASSIGNED
(In reply to Kris Maglione [:kmag] from comment #8)
> I'd been planning to do this in one step, removing the incorrect "backup"
> version code and adding fallback compatible version detection at the same
> time. But the second part is surprisingly difficult the way our code is
> currently structured, so I think I'll just remove the broken backup version
> code first.

That is deff a start thank you!

Comment 11

4 years ago
Commits pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/d955aff10761ee7f01abd250f633c3faec4f7d06
Bug 983798: Remove support for "backup" add-on versions.

https://github.com/mozilla/olympia/commit/69a7345b52ead3044ffe8501b6092cd1fab467da
Merge pull request #644 from kmaglione/drop-backup-version

Bug 983798: Remove support for "backup" add-on versions.
Target Milestone: --- → 2015-08
Duplicate of this bug: 1202130
Product: addons.mozilla.org → addons.mozilla.org Graveyard
Assignee: kmaglione+bmo → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.