98381 - Subscribe dialog ,"Server" label followed by Account Names

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Ninoschka Baca]

Build 2001-08-31-03: WinMe, Mac and Linux

Overview: In the Subscribe dialog there is a label called "Server:" followed by
a drop down list displaying Account Names. 

Expected Results: It should either:
1. Have the label "Server:" followed by a drop down list displaying Server Names
or
2. Have the label "Account Name" followed by a drop down list displaying Account
Names.

Comment 1

[Ninoschka Baca]

I found this bug while duplicating bug# 98225. The user was confused because the
Subscribe dialog stated "Server: new.mcom.com" so they thought "new.mcom.com"
was the server when actually it was just the Account Name. They were expecting
to see "news.mcom.com" so they assumed subscribing would not work since they
thought the server name was wrong.

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

Great catch!  Since I normally accept the default name (which is automatically
generated from the server name in the wizard), I hadn't thought of this.  

Comment 3

[jglick]

Would recommend "Account:". Cc'ing Robin. Also right align the label instead of 
left align so there isn't a big gap.

Comment 4

[jglick]

http://www.mozilla.org/mailnews/specs/subscribe/

Formatting of doc got a little messed up, will fix soon.

Comment 5

[Bradley Hart]

Taking, I have a fix for this. Patch coming soon.

Comment 6

[Bradley Hart]

Attachment: patch to change the label and align the label to the right

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

Nice job Bradley.  r=[e-mail], assuming Robin is fine with Account 
(as Jennifer seems to be).

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Screenshot from my tree with this patch

Comment 9

[jglick]

looks good, thank you :-)

Comment 10

[robinf]

Looks good. 

Comment 11

[(not reading, please use [e-mail] instead)]

Comment on attachment 49539 [details] [diff] [review]
patch to change the label and align the label to the right

sr=sspitzer

Comment 12

[[e-mail] (gone - use [e-mail] instead)]

Landed on the trunk, do we want this on the branch?

Comment 13

[robinf]

Please be aware that today (9/17) is our deadline for handing off the online
help to the localization team. Making this change on the branch after today will
require updating the online help to reflect the new label.

Comment 14

[[e-mail] (gone - use [e-mail] instead)]

Okay, marking fixed, since I landed this on the trunk.

Comment 15

[Scott MacGregor]

well if we want it for the branch it needs an nsbranch keyword. It would also
need approval from localization since we are changing a string from "Server" to
"Account". 

I'll bring it up at the PDT meeting today.

Comment 16

[Michele Carlson]

If PDT gives this a PDT+, then we'll approve it too for l10n change.
Please check it in before the end of this week or it is not approved.
thanks

Comment 17

[[e-mail] (gone - use [e-mail] instead)]

Re-opening, for PDT consideration.

Comment 18

[Jaime Rodriguez, Jr.]

nsbranch+ and PDT+ per PDT.

Comment 19

[(not reading, please use [e-mail] instead)]

fixed on branch and trunk.  marking fixed.

Comment 20

[Blake Ross]

Most/all apps I've seen left-align, and so do we within Mozilla.  What's
different about this dialog?

Comment 21

[Scott MacGregor]

let's track that in a new bug. 

Comment 22

[Scott MacGregor]

filed 100384 to track left justifying the account name in the subscribe dialog.

Comment 23

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED.

BRANCH

RedHat 7.1 - 2001-09-19
Windows 2K - 2001-09-19
Mac OS 9.1 - 2001-09-19

TRUNK

RedHat 7.1 - 2001-09-19-08
Windows 2K - 2001-09-19-04
Mac OS 9.1 - 2001-09-19-08