983810 - [B2G][FTU] 'Refresh' button is present in the header of every page during First Time Experience

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Tony Nguyen]

Attachment: screenshot

Description:
The 'Refresh' button is present on all the pages in the FTE/FTU and can be tapped to refresh Network List. Tapping the button will then display a "Scanning for networks" overlay on the screen. 

Repro Steps:
1) Updated Buri to BuildID: 20140314093423
2) Navigate to Settings app > Device Information > More Information
3) Tap on 'Reset Phone'
4) Tap on 'Reset'

Actual Result: 
'Refresh' button appears in the header of all pages during FTU/FTE

Expected Result:
'Refresh' button doesn't appear in the hader of all during FTU/FTE

Environmental Variables:
Device: Buri Master M-C mozRIL
BuildID: 20140314093423
Gaia: 1cef557f9e9a865d1bf49d99a8f1cca1f0f4f5c4
Gecko: 142911d6d987
Version: 30.0a1
v1.2-device.cfg

Attached: screenshot

Comment 1

[Jason Smith [:jsmith]]

This was definitely caused by bug 968483.

Comment 2

[Jason Smith [:jsmith]]

Should be fixed per the backout of the above bug - I've asked someone to verify that the issue no longer reproduces with the latest gaia changesets.

Comment 3

[Peter Bylenga [:PBylenga]]

I can verify that the issue no longer reproduces with the latest gaia changesets.

v1.4 Environmental Variables:
Device: Buri v1.4 MOZ
BuildID: 20140313131233
Gaia: d058b4851157dededea27157983087c1920d08da
Gecko: fe40387eba1a
Version: 30.0a1
Firmware Version: v1.2-device.cfg

Comment 4

[Casey Yee]

This problem is caused by a style in FTE being overwritten:

/apps/communications/ftu/css/style.css 
line: 163
.no-options header menu {
  display: none;
}

by:
/shared/style/headers.css
line: 135
  order: 3;
  display: flex;
  height: 100%;
  margin: 0;
  padding: 0;
}

The "display: flex" has higher specificity than the style in FTE.  To fix this:
1. We should move the rule in FTU to headers.css
2. Re-write the selector so that it honers the .no-option style.

This will be the fix post 968483 landing, that this is dependent on.

Comment 5

[Jason Smith [:jsmith]]

Regressions are flagged as blocking the original bug, not dependent. See https://ask.mozilla.org/question/200/should-a-regression-bug-block-or-depend/.

Comment 6

[Stephany Wilkes]

Resolving this as WONTFIX for 1.4 since bug #968483 will not be landing.

Jason, if this still occurs in FTE and needs to be fixed separately (i.e. independent of bug #968483) please let UX know.