983847 - Frequent CSS errors in spectrum-frame.xhtml

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Dave Townsend [:mossop]]

These errors keep showing up in tests:

JavaScript Warning: "Unknown property 'user-select'.  Declaration dropped." {file: "chrome://browser/content/devtools/spectrum.css" line: 88 column: 13 source: "  user-select: none;"}
JavaScript Warning: "Error in parsing value for 'top'.  Declaration dropped." {file: "chrome://browser/content/devtools/spectrum-frame.xhtml" line: 0 column: 0 source: "NaNpx"}
JavaScript Warning: "Error in parsing value for 'left'.  Declaration dropped." {file: "chrome://browser/content/devtools/spectrum-frame.xhtml" line: 0 column: 0 source: "NaNpx"}
JavaScript Warning: "Error in parsing value for 'top'.  Declaration dropped." {file: "chrome://browser/content/devtools/spectrum-frame.xhtml" line: 0 column: 0 source: "NaNpx"}
JavaScript Warning: "Error in parsing value for 'left'.  Declaration dropped." {file: "chrome://browser/content/devtools/spectrum-frame.xhtml" line: 0 column: 0 source: "NaNpx"}

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch

Comment 2

[Dave Townsend [:mossop]]

Attachment: patch

Left some debugging bits in there

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8391500 [details] [diff] [review]
patch

Review of attachment 8391500 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Will be good to get rid of these annoying css errors. Thanks for the patch.

Comment 4

[Dave Townsend [:mossop]]

https://hg.mozilla.org/integration/fx-team/rev/3dea813b6eea

Comment 5

[Dave Townsend [:mossop]]

And https://hg.mozilla.org/integration/fx-team/rev/a3d1b8a1c138 because somehow I managed to land the wrong patch :(

Comment 6

[Dave Townsend [:mossop]]

https://hg.mozilla.org/mozilla-central/rev/3dea813b6eea
https://hg.mozilla.org/mozilla-central/rev/a3d1b8a1c138