983892 - Box model tab's background is too dark - can't read dimensions

Status: VERIFIED FIXED

(DevTools :: Inspector, defect)

Description

[Heather Arthur [:harth]]

Attachment: Screenshot 2014-03-14 16.24.11.png

Check out the "Box Model" tab in the devtools Inspector. The background is dark blue and the text listing the dimensions is only slightly different.

We should make the background white or grey to match the theme.

Comment 1

[Heather Arthur [:harth]]

Attachment: Quick fix - remove the blue grid background image

This is a quick fix, just removes that background image and now the background is white. At least it's readable now.

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 8391654 [details] [diff] [review]
Quick fix - remove the blue grid background image

Review of attachment 8391654 [details] [diff] [review]:
-----------------------------------------------------------------

Do you think making the text white instead of removing the background would be a better solution here? I'm personally ok with this though.

Comment 3

[Heather Arthur [:harth]]

Attachment: White background

Thanks for the review. I think the white fits better with the light theme than that dark blue grid.

Comment 4

[Heather Arthur [:harth]]

Attachment: Use 'theme-sidebar' instead of 'theme-body' class to get a light grey

I figured out that all the other inspector tabs are using a "theme-sidebar" class, whereas the box model was using a "theme-body" class. I changed it to the "theme-sidebar" class, and now it's light grey light the rest of the tabs. Looks good I think.

The dark theme looks the same because we still have the background image.

Comment 5

[Victor Porof [:vporof][:vp]]

Comment on attachment 8391667 [details] [diff] [review]
Use 'theme-sidebar' instead of 'theme-body' class to get a light grey

Review of attachment 8391667 [details] [diff] [review]:
-----------------------------------------------------------------

<3

Comment 6

[Heather Arthur [:harth]]

https://hg.mozilla.org/integration/fx-team/rev/06ec9263bd5c

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/06ec9263bd5c