Closed Bug 983921 Opened 8 years ago Closed 8 years ago

test_SimpleTestGetTestFileURL.html isn't getting run

Categories

(Testing :: Mochitest, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: billm, Assigned: billm)

References

Details

Attachments

(1 file)

I'm pretty sure this is a mistake. We skip over tests with SimpleTest in their path [1], which excludes this test. I have a patch that renames the test, but maybe we should fix the code that excludes these tests. It seems pretty error-prone. What do you think we should do, Ted?

[1] http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/server.js#396
Flags: needinfo?(ted)
Let's just rename the test for now, we can just remove all that server.js code once the use-manifests code sticks anyway.
Flags: needinfo?(ted)
Attached patch rename-testSplinter Review
Assignee: nobody → wmccloskey
Status: NEW → ASSIGNED
Attachment #8391624 - Flags: review?(ted)
Comment on attachment 8391624 [details] [diff] [review]
rename-test

Review of attachment 8391624 [details] [diff] [review]:
-----------------------------------------------------------------

doing a drive by here. I did a quick look and didn't find any other files that seem to match this SimpleTest pattern.
Attachment #8391624 - Flags: review?(ted) → review+
Thanks. I also had to make a small change to the test so it would pass.
https://hg.mozilla.org/integration/mozilla-inbound/rev/3917d9bfb8fe
https://hg.mozilla.org/mozilla-central/rev/3917d9bfb8fe
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.