Mac OS X: also check USE_64 when config.guess detects the CPU as x86_64

RESOLVED FIXED in 4.10.5

Status

defect
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: wtc, Assigned: wtc)

Tracking

4.10.5
4.10.5
x86_64
macOS

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch PatchSplinter Review
On my Mac OS X computer, uname -m returns "x86_64" and uname -p
returns "i386".

The nspr/build/autoconf/config.guess script in NSPR 4.10.4
detects this system as "i386-apple-darwin13.1.0". I just updated
the nspr/build/autoconf/config.guess script to the latest version
from the upstream GNU config project, and now the script detects
this system as "x86_64-apple-darwin13.1.0". This causes NSPR to
do a 64-bit build by default.

The attached patch makes NSPR also check the USE_64 variable
when the CPU is x86_64.
Attachment #8391659 - Flags: review?(kaie)
Comment on attachment 8391659 [details] [diff] [review]
Patch

r=kaie
Attachment #8391659 - Flags: review?(kaie) → review+
Patch checked in: https://hg.mozilla.org/projects/nspr/rev/2ff1ed8933e2
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.