983946 - CppEclipse fails if objdir is under tree

Status: RESOLVED DUPLICATE of bug 1057986

(Firefox Build System :: General, defect)

Description

[Benoit Girard (:BenWa)]

Andrew was getting eclipse failures opening the src tree external resources (eclipse symlink) because his objdir/workspace was inside the source external link.

Comment 1

[Martin Thomson [:mt:]]

I can confirm this.  The message is:
  '/Users/me/code/gecko-dev' is not a valid location for linked resources.

Which searching leads me to discover:
http://help.eclipse.org/helios/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fapi%2Forg%2Feclipse%2Fcore%2Fresources%2FIWorkspace.html
---
 [...] a link location must also obey the following rules:

    must not overlap with the platform's metadata directory
    must not be the same as or a parent of the root directory of the project the linked resource is contained in
---

It's trivial to work around by moving $OBJDIR and maybe that's the best solution here.  Shame that this is the (easy) default for mach.

Comment 2

[Benoit Girard (:BenWa)]

Have you checked if https://bugzilla.mozilla.org/show_bug.cgi?id=981495 part 1 is sufficient? We can properly filter on the obj directory.

Comment 3

[Martin Thomson [:mt:]]

(In reply to Benoit Girard (:BenWa) from comment #2)
> Have you checked if https://bugzilla.mozilla.org/show_bug.cgi?id=981495 part
> 1 is sufficient? We can properly filter on the obj directory.

It is not sufficient.  That fix is in my tree and .project file.

Comment 4

[Benoit Girard (:BenWa)]

Roc you added a filter for this. Have you ran into this error? Andrew Overholt also ran into this.

I'm wondering if we're missing something or perhaps I should make an external object dir a pre-req to using eclipse (and check it when generating the project).

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I imported the generated projects into a workspace that is not under my srcdir.

Comment 6

[Benoit Girard (:BenWa)]

Ahh, that might be a problem since I store some settings in the workspace x_X.

Comment 7

[Benoit Girard (:BenWa)]

Patch in bug 1057986