983969 - Remove "Click here to..." clutter from unifinder trees

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

This is bug 881073, but for calendar.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 2

[Martin Schröder [:mschroeder]]

Comment on attachment 8391677 [details] [diff] [review]
Fix - v1

Looks good, r=mschroeder.

Comment 3

[Stefan Sitter [:ssitter]]

If the goal is ux-consistency, should we change the capitalization as well? Thunderbird uses lower case words like in "Sort by priority" but Lightning uses upper case words like in "Sort by Priority".

Comment 4

[Martin Schröder [:mschroeder]]

Comment on attachment 8391677 [details] [diff] [review]
Fix - v1

Stefan has a point about the consistency with Thunderbird. Did not take that into account when reviewing the patch.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Good catch, taking care before push.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

Tree is closed, here is the patch for checkin.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/a9d68765f14e

Comment 8

[RickieES aka Ricardo Palomares]

I think this bug should be reopened, as calendar.dtd is no longer a valid DTD file, due to lines 30 and 31 including the string "--":

http://www.w3.org/TR/2008/REC-xml-20081126/#sec-comments

    For compatibility, the string " -- " (double-hyphen) MUST NOT occur within comments.]

Comment 9

[Stefan Plewako [:stef]]

This also confuses l10n dashboard - it is reporting missing string even when there is no comment/error in l10n file.

Comment 10

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Bustage Fix

Thanks for the hint, I was wondering why the UI is broken. I have rs=Archaeopteryx via IRC on this one, but the trees are closed for merge.

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

The bustage fix will likely get pushed after the merge, in that case please push to aurora too.

Comment 12

[Mark Banner (:standard8)]

I've pushed this fix ahead of the merge:

https://hg.mozilla.org/comm-central/rev/465fb05fd061