984007 - After localizing a KB article with updated information, the dashboard page still shows "Update needed"

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P3)

Description

[Safwan Rahman (:safwan)]

Attachment: The screenshot of problem

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20140212131424

Steps to reproduce:

When a English KB article is changed, other local's dashboard page awer them to update the article by showing "Update Needed" or "Immediate Update Needed" at the right side of the article's name. when I update the article in my language with the updated information and submit it for review. And come back to the my local's Dashboard Page.


Actual results:

Though after updating the article in my language with updated information and submitting it, still the dashboard page shows that the article needs update. It shows "Update Needed" or "Immediate Update Needed". It does not show "Review needed" though my updated information is waiting for review.


Expected results:

As I have updated the Article with updated information and it is waiting for review, the Dashboard page should show "Review Needed" instead of "Update Needed" or "Immediate Update Needed". As the current system, the locale Dashboard page is showing "Update Needed" or "Immediate Update Needed" though the the Article is updated. Therefore other localizer thinks that the Article needs update localization and they try to localize it. But fact is, already the article has been localized by other person. Also as the Dashboard page does not show "Review Needed", The reviewer can not concern on it for review.

Comment 1

[Ashickur Rahman]

Hey Safwan, thanks for the report. Can you give us a test case. In this case please update a KB and and give us screenshot of the l10n dashboard before updating the KB , updated KB and l10n dashboard after updating the KB.

Comment 2

[Safwan Rahman (:safwan)]

Hello Ashickur,
Thanks a lot for your concern in this bug. Please be informed that I have already submitted a test case with the screenshot of the l10n Dashboard after updating and also attached screenshot of the history of the KB article after updating. I hope to attach another test case with the "screenshot of the l10n dashboard before updating the KB". I would be glad if you please see the attachment of this bug. there I have already attached screenshot of the "history of updated KB and l10n dashboard after updating the KB." I hope you will take your time and see the attachment of this bug.

Comment 3

[Safwan Rahman (:safwan)]

Comment on attachment 8391732 [details]
The screenshot of problem

The "Sumo.PNG" is screenshot of the history of KB Article after updating.

The "Sumo1.PNG" is screenshot of the l10n KB Dashboard after updating the KB Article.

Comment 4

[Safwan Rahman (:safwan)]

Comment on attachment 8391732 [details]
The screenshot of problem

The "Sumo.PNG" is screenshot of the history of KB Article after updating.

The "Sumo1.PNG" is screenshot of the l10n KB Dashboard after updating the KB Article.

Comment 5

[Ashickur Rahman]

Hey Safwan, 
thanks for the update and for opening the bug.

Comment 6

[Safwan Rahman (:safwan)]

Attachment: Dashboard-before_Update.PNG

Screenshot of Dashboard before Updating The KB Article.

Comment 7

[Safwan Rahman (:safwan)]

Attachment: Dashboard-after_Update.PNG

Screenshot of Dashboard after Updating The KB Article.

Comment 8

[Safwan Rahman (:safwan)]

Attachment: history-before_Update.PNG

Screenshot of the KB Article's History before Updating The KB Article.

Comment 9

[Safwan Rahman (:safwan)]

Attachment: history-after_Update.PNG

Screenshot of the KB Article's History after Updating The KB Article.

Comment 10

[Safwan Rahman (:safwan)]

(In reply to Ashickur Rahman from comment #1)
> Hey Safwan, thanks for the report. Can you give us a test case. In this case
> please update a KB and and give us screenshot of the l10n dashboard before
> updating the KB , updated KB and l10n dashboard after updating the KB.

Dear Ashickur,
Please go through my latest attachment. I have provided all the information that you have asked. I hope it is helpful. Let me know if more information needed.

Comment 11

[Kadir Topal [:atopal]]

Hi there, Safwan! Thanks a lot for the report. Could you please link to the article that is causing the issue?

As you can see on your dashboard we do actually display "reviewed needed" instead of "update needed" on the localization dashboard when an article has been updated. All the violet squares are "review needed": https://support.mozilla.org/bn-BD/localization/most-visited-translations

However, there is an edge case. Imagine you start localizing an article, but by the the time you are handing it in for review the English version has been updated. Now, we could still display "review needed", but then someone would review an article that would be outdated the moment it is approved. We choose to display "update needed" instead. 

I don't know if that is the case here, so a link to the article in question would be very much appreciated. Thanks!

Comment 12

[Safwan Rahman (:safwan)]

Hi Kadir,
Glad to see you. Please be informed that, the point you have raised that is different from my bug. I have provided screenshot of the problem. let me explain you the fact

1. This problem not only happening with one article, it is happening with every. Below here is 3 of them.
# http://goo.gl/KIOJ0q
# http://goo.gl/yWTkR0
# http://goo.gl/v2xC3U

2. In bn-BD Dashboard page, it is showing all of the 3 needs update.
https://support.mozilla.org/bn-BD/localization/most-visited-translations

3. But see the history of that 3 Article
# http://goo.gl/X0kuqX
# http://goo.gl/5xMnFd
# http://goo.gl/eCkuTx

4. In the history, you can see that I have updated all the 3 Articles.

5. There is no updated revision after my updated localization.
# http://goo.gl/aWRBSp
# http://goo.gl/KC0ssl
# http://goo.gl/aSNr2S

6. But still our Dashboard Page is showing "Update Needed" in the right side of the articles. As I have already updated the article and there is no revision after my update and it is waiting for review, the Dashboard page should show "Review Needed" instead of "Update Needed". 
But the Dashboard page is showing "Update Needed"

I hope it clarify the problem.

Comment 13

[Kadir Topal [:atopal]]

After looking at the articles, here is what seems to be going on:

1.  An Engliish article is written
1.1 The dashboard now says "localization needed"
2.  A translation of the article is made
2.1 The dashboard now says "localized"
3.  The English version is updated
3.1 The dashboard now says "update needed" 
4.  Someone updates the localization and submits for review.
4.1 The dashboard now says "review needed"
5.  The English version is updated again
5.1 The dashboard now says "update needed"
6. Someone updates the localization based on the unreviewed update in (4)
6.1 The dashboard still says "update needed"

Why does the dashboard say "update needed" in even though the localization is already up to date? Because the last localization update is based on a revision that was created before the current version of the English article. That's pretty okay, if your review queue is short, but it can lead to bad results when changes have to wait for a long time to be reviewed.

CC'ing Ricky, to make sure I didn't make this up ;)

Comment 14

[Safwan Rahman (:safwan)]

Hello Topal,
Everithing you written, is ok. But 1 thing is wrong. The process you have written, this should be happen, But in the real case, it does not happen. let me explain.
You have written

"3.  The English version is updated
3.1 The dashboard now says "update needed" 
4.  Someone updates the localization and submits for review.
4.1 The dashboard now says "review needed""

But in the real case, below thing happen

3.  The English version is updated
3.1 The dashboard now says "update needed" 
4.  Someone updates the localization and submits for review.
4.1 The dashboard now says "Update needed"

It is the bug which need to be fixed. I hope now you have understand

Comment 15

[Ricky Rosario [:rrosario, :r1cky]]

I'm not convinced this is a bug. If a localizer tries to go edit an article with reviews pending, they will get a big warning at the top of the page about it. Isn't that enough?

Comment 16

[Safwan Rahman (:safwan)]

Rosario, I have explained in my last comment about the bug. The bug is 

4.  Someone updates the localization and submits for review.
4.1 The dashboard now says "Update needed"

Comment 17

[Ashickur Rahman]

Hey Ricky

As a localization reviewer, it is hard for us to identify whether a KB update is localized or not. Because it always says update needed. So as a reviewer I will not check that KB update is localized or not. I will escape that KB, until a localizer inform me to review the update. And I think it is a endless loop.

Comment 18

[Ricky Rosario [:rrosario, :r1cky]]

I understand that. I'm just saying that it technically might still need an update depending on what happens in the review. There is a separate dashboard for reviewers that shows what documents are in the review queue already.

Comment 19

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Ashickur Rahman from comment #17)
> As a localization reviewer, it is hard for us to identify whether a KB
> update is localized or not. Because it always says update needed. So as a
> reviewer I will not check that KB update is localized or not. I will escape
> that KB, until a localizer inform me to review the update. And I think it is
> a endless loop.

Reviewers should be working off the "Needs review" list on the localization dashboard. It's the other tab there. See -> http://cl.ly/image/2737140a3E2j

Comment 20

[Safwan Rahman (:safwan)]

But, fact is, when a localizer update an article, it should be shown "review needed" instead of "update needed". So other localizer will easily understand the article has already updated with localization and waiting for review. But if the dashboard page shows "update needed", other localizer will try to localize it, and it may make them confuse

Comment 21

[Ricky Rosario [:rrosario, :r1cky]]

We already handle that by showing the localizer a big warning if they try to edit the translation -> http://cl.ly/image/3A0a0w0N2v1X

Comment 22

[Ashickur Rahman]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #19)
> Reviewers should be working off the "Needs review" list on the localization
> dashboard. It's the other tab there. See -> http://cl.ly/image/2737140a3E2j

I have never tried before. Thanks for it. 

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #21)
> We already handle that by showing the localizer a big warning if they try to
> edit the translation -> http://cl.ly/image/3A0a0w0N2v1X

Yes, it always shows a message. Is there any specific reason that we are following the current way?

Comment 23

[Safwan Rahman (:safwan)]

But fact is, why we don't show "Review needed" localizer in the dashboard page for the article? Why we show localizer "Update needed" though it has been updated? 
It makes the localizer confuse and kill the time.

Comment 24

[Safwan Rahman (:safwan)]

Rosario, Why we dont handle that by showing localizer "review needed" in the Dashboard page? So that they will be warned before starting localization of a article.
Whenever our localizer update an article and after that they see in the dashboard that the article still marked as "update needed", they become so confuse.

Comment 25

[Safwan Rahman (:safwan)]

Can I make you understand regarding the bug?

Comment 26

[Ricky Rosario [:rrosario, :r1cky]]

I don't know how hard or easy that would be. But it isn't my call to change that.

Comment 27

[Ricky Rosario [:rrosario, :r1cky]]

Actually, looking at the German dashboard, I see it is working as you are describing you want it. So maybe i don't understand this after all.

If you look at your own attachment, the text next to the purple square should say "Review needed" if it's localized properly. If it's yellow, it's because the revisions pending review dont bring the article fully up to date.

I think this is what Kadir was getting at.

Comment 28

[Safwan Rahman (:safwan)]

Can you please show screenshot where it is working?

I am not seeing it in work in bn-BD Dashboard

Comment 29

[Safwan Rahman (:safwan)]

I have attached 2 screenshot above.
1.  Dashboard-before_Update.PNG
2.  Dashboard-after_Update.PNG

Did u see it?
I have attached 2 screenshot above.
1.  Dashboard-before_Update.PNG
2.  Dashboard-after_Update.PNG

Did u see it?

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #27)
If it's yellow, it's because the revisions pending review dont bring the article fully up to date.
> 
> I think this is what Kadir was getting at.

No. the revision brought the article fully up to date. 
And still, if any revision brings any article fully up to date, the dashboard page still shows "update needed" as I showed in my screenshots

Comment 30

[Ricky Rosario [:rrosario, :r1cky]]

Kadir to provide STR.

Blocking out 2pts to work on this.

Comment 31

[Kadir Topal [:atopal]]

Steps to reproduce:

1. Create a new English article. Approve it. => L10n dashboard says localization needed
2. Create article translation. Approve it. => L10n dashboard says localization up to date.
---
3. Update English article. Approve it => L10 dashboard says localization needs update.
4. Update localized article => L10n dashboard still says localization needed, even though it should now say: Review needed.

Curious detail: The article will be listed in the "needs review section" too.

Expected behavior: 
1. Remove article from "Localization" part of L10n dashboard. Show it only in the "needs review section".
2. In the "most visited translations" list, show correct status as "needs review", not as "needs update".

Comment 32

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod now:

https://github.com/mozilla/kitsune/commit/b440ce32e20cdabb90ff1d9048295f0af745f149