984014 - Telemetry experiments: test update mechanism

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Georg Fritzsche [:gfritzsche]]

Add test coverage for updating to test_api.js from bug 974009 or add new test with similar pattern.

* add e.g. browser/experiments/test/experiment-1a.xpi
* fetch manifest that provides experiment-1.xpi
* trigger experiment-1 activation
* fetch manifest with experiment-1a.xpi
* check that experiment-1a.xpi is now active (e.g. changed name or description)

Comment 1

[Georg Fritzsche [:gfritzsche]]

Attachment: Test updating active experiment.

https://tbpl.mozilla.org/?tree=Try&rev=b67c8ff8a5ae

Comment 2

[Benjamin Smedberg]

Are we going to use this bug or another to cover the other cases where a manifest is updated? In particular:

* check that "disabled" force-kills an experiment
* check that "frozen" *doesn't* force-kill a runnin experiment but does prevent it from starting
* check that removing the experiment from the manifest completely doesn't force-kill the experiment but the current conditions still apply

Comment 3

[Georg Fritzsche [:gfritzsche]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> Are we going to use this bug or another to cover the other cases where a
> manifest is updated?

Filed bug 984387.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8392194 [details] [diff] [review]
Test updating active experiment.

Review of attachment 8392194 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/experiments/test/xpcshell/test_api.js
@@ +724,5 @@
> +  list = yield experiments.getExperiments();
> +  Assert.equal(list.length, 1, "Experiment list should have 1 entry now.");
> +  Assert.equal(list[0].id, EXPERIMENT1_ID, "Experiment 1 should be the sole entry.");
> +  Assert.equal(list[0].active, true, "Experiment 1 should be active.");
> +  Assert.equal(list[0].name, "Test experiment 1", "Experiments name should match.");

we should probably have the strings "Test experiment 1" and "Test experiment 1.1" (below) as consts together with EXPERIMENT1A_XPI_NAME et al.

Comment 5

[Georg Fritzsche [:gfritzsche]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9530b0d7341b

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9530b0d7341b