984057 - When backspacing the last character of the current page in Firefox for Android's URL bar, it frequently reappears (highlighted, due to autosuggest) and needs to be backspaced again

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Daniel Holbert [:dholbert]]

[ This doesn't happen 100% reliably, but it happens to me pretty reliably with "about:home" and "about:addons" and I just reproduced it with https://www.mozilla.org/en-US/ and http://homestarrunner.com/ ]

STR:
 1. Visit any URL. (Let's say about:addons for now.)
 2. Tap the URLbar.
      --> entire URL is highlighted
 2. Tap blank space to the right of the text, to get a cursor.
 3. Hit backspace button, wait a second, & hit the backspace button again.

EXPECTED RESULTS: The last two characters ("ns" in this case) should get backspaced.

ACTUAL RESULTS: Some significant fraction of the time, the last character disappears *and then reappears* (due to autosuggest?), which means my second backspace clears it again.

In other words, when I delete the last character, Firefox immediately autosuggests it back for me, which means I have to backspace it again.

Comment 1

[Daniel Holbert [:dholbert]]

(This bug is annoying because it means you can't reliably predict how many times you need to hit backspace, when you're editing a URL.

e.g. if i'm currently at "about:home" and want to go to "about:", I'd expect I could just tap backspace 4 times and be done. But this bug means that doesn't reliably work.)

Comment 2

[Aaron Train [:aaronmt]]

Which keyboard/OS/device?

Comment 3

[Daniel Holbert [:dholbert]]

This is with Nightly running on a Nexus 4.

I also just reproduced with Nightly on my Nexus 7. (first try, starting at "about:home")

Comment 4

[Daniel Holbert [:dholbert]]

(using the stock Android keyboard; no special keyboard app)

Comment 5

[Daniel Holbert [:dholbert]]

Reproduced in Firefox Beta (28.0) on my Nexus 7 on the first try, too.

Wasn't able to reproduce in Firefox Release (27.0), after a few attempts, so I suspect this is a regression.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

I can't get this reproduce with about:home, mainly because about:home is not a bookmark for me and is not saved in history. But I can get it to happen with about:firefox. It only seems to happen for the 'x' in about:firefox though.

Comment 7

[Daniel Holbert [:dholbert]]

Yes, I've only ever seen it happen with the last character of the URL.

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Still reproducible. Bug 994472 is a major refactoring of autocomplete so we should check again after that bug lands.

Comment 9

[Aaron Train [:aaronmt]]

Is this still an issue now that the above mentioned bug has landed?

Comment 10

[Daniel Holbert [:dholbert]]

I can still reproduce this in Nightly (33.0a1 2014-07-20), at "about:firefox", on my Nexus 4.

It also seems that I can only reproduce it *with URLs that I've bookmarked*.  Just now, I initially could repro at about:firefox (bookmarked) but not with about:addons (not bookmarked), but then I tapped options & hit the star when viewing about:addons, and then I could reproduce it there.

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Reset autocomplete states when needed (v1)

This patch actually fixes several bugs, including
* Bug where we try to autocomplete after backspacing in some cases
* Bug where we try to autocomplete when editing search suggestions
* Bug where the cursor is hidden when editing search suggestions

Comment 12

[Wesley Johnston (:wesj)]

Comment on attachment 8469520 [details] [diff] [review]
Reset autocomplete states when needed (v1)

Review of attachment 8469520 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable.

Comment 13

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/613d9b80d7be

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/613d9b80d7be

Comment 15

[miralobontiu]

Hi,

I was not able to reproduce the issue.

Tested with:
Browser / Version: Firefox Mobile Nightly 64.0a1 (2018-09-11)
Operating System: HTC 10 (Android 8)

Therefore, I will remove the qe-verify+ flag.
Thank you!