984089 - Remove the overridden TAB keymap in editor.js

Status: NEW

(DevTools :: Source Editor, defect)

Description

[Girish Sharma [:Optimizer]]

As far as I can see CodeMirror by default has exactly the same behavior as what is being tried to achieve in editor.js's constructor of Editor class. We should not override it as it makes it impossible for Firefox Add-ons to override the Tab key via the extraKeys route.

Comment 1

[Anton Kovalyov (:anton)]

If you go to http://codemirror.net/ and pres [tab] in the text editor, a hard-tab will be inserted instead of two spaces. Hence why we do it in the editor.js

Comment 2

[Girish Sharma [:Optimizer]]

So the right way is to add an extra key, instead of overriding the tab key completely. And then using the insertSoftTab command of CM rather than replacing tabs with space and stuff.

I will attach a patch.

Comment 3

[Anton Kovalyov (:anton)]

That code was taken from the manual: http://codemirror.net/doc/manual.html#keymaps

Comment 4

[Anton Kovalyov (:anton)]

What we should do, instead, is check whether extraKeys has something to override the [tab] and then **append** to our current logic.