984151 - Make the contacts image pull up effect smoother

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

There is a lot of layers creation / destruction, repaints when showing the contacts photo. It makes it jerky.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug984151.patch

This patch makes the pull up effect smoother by preparing the UI to be transformed with will-change. It also calls event.preventDefault() on touch events in order to make sure the platform is not doing unnecessary work.

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8391929 [details] [diff] [review]
bug984151.patch

Review of attachment 8391929 [details] [diff] [review]:
-----------------------------------------------------------------

Working like a charm!

Thanks Vivien for this patch!

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/379d54c223873a888dd4d374aadc05b44b63f8f6

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Relanded as this has been backouted for some unknown reasons...