Closed
Bug 984151
Opened 12 years ago
Closed 12 years ago
Make the contacts image pull up effect smoother
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Firefox OS Graveyard
Gaia::Contacts
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vingtetun, Assigned: vingtetun)
References
Details
Attachments
(1 file)
|
5.27 KB,
patch
|
arcturus
:
review+
|
Details | Diff | Splinter Review |
There is a lot of layers creation / destruction, repaints when showing the contacts photo. It makes it jerky.
|
Assignee | |
Comment 1•12 years ago
|
||
This patch makes the pull up effect smoother by preparing the UI to be transformed with will-change. It also calls event.preventDefault() on touch events in order to make sure the platform is not doing unnecessary work.
Attachment #8391929 -
Flags: review?(francisco.jordano)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8391929 [details] [diff] [review]
bug984151.patch
Review of attachment 8391929 [details] [diff] [review]:
-----------------------------------------------------------------
Working like a charm!
Thanks Vivien for this patch!
Attachment #8391929 -
Flags: review?(francisco.jordano) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Assignee: nobody → 21
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•12 years ago
|
||
Relanded as this has been backouted for some unknown reasons...
You need to log in
before you can comment on or make changes to this bug.
Description
•