984238 - [tarako] keyboard sometimes didn't appear when sending sms through contact

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[Peipei Cheng (needinfo if you need my action)]

Attachment: adb logcat

Test environment: tarako v1.3t
-------------------------------------------------------------
gaia revision:"15385efaf840090391d182d821eaeda6d25cf0e0"
gecko revision="88b69c90707a51060b3c3164c95a16766553985d"
build ID: 20140317060055


Steps to reproduce
-------------------------------------------------------------
1.Launch Contact and create a contact with phone number
2.Select the contact created and open the contact detail page
3. Tap on send SMS button, SMS is launched
4. Tap on the Message body to input
   --> Sometimes keyboard cannot be launched. The reproduce rate is 3/5.

Log
--------------------------------------------------------------
Attached is the adb log. Test starts at: 03-17 13:52:14.031

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

how easy is it to reproduce this? thanks

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

It's pretty easy to reproduce.  It's a general keyboard issue.  First launch and tapping into any text field for any app ( ie SMS, email setup ) does not show the keyboard.

This bug does not occur on 1.3 Buri on today's build ( build id : 20140317004001 )

Comment 3

[[:fabrice] Fabrice Desré]

I will investigate, since there are strange things in the logcat.

Comment 6

[Peipei Cheng (needinfo if you need my action)]

The reproduce rate on today's build is lower: 1/10.

gaia revision="abf210d0ea2f6bf1c43be46fde67521aa36af0db"
gecko revision="3fb98dffed72c590ad831ae56a711ce406239720"
build id: 20140318104052

But on build 20140317060055, it's very easy to reproduce. The rate is about 3/5.

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Marketplace shows a higher precentage of reproduction:
see bug 984635

It was marked off as a duplicate; I am not sure if it is.
I noticed that the Chinese keyboard is on by default?  Is that intentional?

Comment 8

[[:fabrice] Fabrice Desré]

Hm, I could not reproduce. :(

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

William, could you help us and see if this reproduces? Thanks.

Comment 10

[William Hsu [:whsu]]

Hi, Tim,

It is easy to reproduce it.
I have filed a duplicate bug (Bug 984319).
Thanks.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Update: I am getting an unknown old build from William and I cannot reproduce this bug. William said he will be able to tackle this bug by verifying against each build.

I suspect this is a platform regression since this part of code in 1.3/1.3t didn't change much in the development cycle.

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

With app manager I can now confirm the problem lies on keyboard manager; it failed to recreate keyboard iframe after memorypressure event cause the previous iframe being removed.

Temporary assign this bug to myself before Rudy can finish his last 1.3 bug.

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I mistakenly wiped the tarako William gave me so I ask him to re-flash the build for me.

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This cause of this bug is because memorypressure event will kill the keyboard we are about to show....

E/GeckoConsole( 1413): Content JS LOG at app://system.gaiamobile.org/js/keyboard_manager.js:91 in km_debug: [Keyboard Manager] mozmemorypressure event
E/GeckoConsole( 1413): Content JS LOG at app://system.gaiamobile.org/js/keyboard_manager.js:91 in km_debug: [Keyboard Manager] mozmemorypressure event
E/GeckoConsole( 1413): Content JS LOG at app://system.gaiamobile.org/js/keyboard_manager.js:91 in km_debug: [Keyboard Manager] get focus event textarea
E/GeckoConsole( 1413): Content JS LOG at app://system.gaiamobile.org/js/keyboard_manager.js:91 in km_debug: [Keyboard Manager] set layout to display: type=text index=0
E/GeckoConsole( 1413): Content JS LOG at app://system.gaiamobile.org/js/keyboard_manager.js:91 in km_debug: [Keyboard Manager] mozmemorypressure event

Comment 15

[[:fabrice] Fabrice Desré]

Tim, we could ignore memory pressure during N seconds after "set layout to display:..." ?

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

With a quick patch I will be am able to protect the keyboard when it's being launched (but not shown yet)

E/GeckoConsole( 2593): Content JS LOG at app://system.gaiamobile.org/js/keyboard_manager.js:91 in km_debug: [Keyboard Manager] get focus event textarea
E/GeckoConsole( 2593): Content JS LOG at app://system.gaiamobile.org/js/keyboard_manager.js:91 in km_debug: [Keyboard Manager] set layout to display: type=text index=0
E/GeckoConsole( 2593): Content JS LOG at app://system.gaiamobile.org/js/keyboard_manager.js:91 in km_debug: [Keyboard Manager] mozmemorypressure event
E/GeckoConsole( 2593): Content JS LOG at app://system.gaiamobile.org/js/keyboard_manager.js:91 in km_debug: [Keyboard Manager] resizeKeyboard: 230

The keyboard event on the 3rd line did not remove the keyboard.

Comment 17

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Fabrice Desré [:fabrice] from comment #15)
> Tim, we could ignore memory pressure during N seconds after "set layout to
> display:..." ?

I ended up protect the keyboard with it's active status.

Comment 18

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:v1.3t PR#17422

Comment 19

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8394576 [details] [review]
mozilla-b2g:v1.3t PR#17422

I thought about having the |active| state kept for each keyboard frame, but for 1.3 there is only going to be one keyboard frame, so it doesn't really matter.

Comment 20

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#17423

Comment 21

[[:fabrice] Fabrice Desré]

Comment on attachment 8394576 [details] [review]
mozilla-b2g:v1.3t PR#17422

I left a comment on github

Comment 22

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8394576 [details] [review]
mozilla-b2g:v1.3t PR#17422

Looks good to me, r+.

Thanks for digging into this issue.

Comment 23

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This can land once the tree reopens.

Comment 24

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/b449a1b703449bc530138d6c7df33736ae88884f
v1.3t:  https://github.com/mozilla-b2g/gaia/commit/ea0653b1329d78a569f2e9a19f763ad8881449e2

Comment 25

[Tim Guan-tin Chien [:timdream] (please needinfo)]

We need this in the 1.4 too.

Comment 26

[bhavana bajaj [:bajaj]]

Tm, can you please request approval-gaia-v1.4: ? and help fill in the details to consider the 1.4 backport ?

Comment 27

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8394576 [details] [review]
mozilla-b2g:v1.3t PR#17422

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 957880
[User impact] if declined: non-oop'd keyboard will sometimes not shown.
[Testing completed]: manually.
[Risk to taking this patch] (and alternatives if risky): unlikely, minimal code change.
[String changes made]: no

Comment 28

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/e1b22e23183f957068fc3d9c8dd302331dad5c3b

Comment 29

[William Hsu [:whsu]]

Verified it on latest Tarako build.
Thanks for the help.

* Build Info.:
 - Gaia      d8ff994bd96c37ba9a93c343932a5441a78a0eec
 - Gecko     6db37b3f76b4fe2aa6f8fb5ae9e036ed99344772
 - BuildID   20140327060053
 - Version   28.1

* Result:
 - Cannot reproduce

Comment 30

[[:fabrice] Fabrice Desré]

Just changing the status-b2g-V1.3T flag to not mess up with my uplift query.

Comment 31

[Roland Kunkel [:RolandK]]

Verified for v1.3T. I am unable to reproduce this issue on the latest v1.3T Tarako build:

v1.3T Environmental Variables:
Device: Tarako v1.3T MOZ RIL
BuildID: 20140530014002
Gaia: e68858693b71d917c9c5ee7e215f7ceea04635f7
Gecko: 1945abae19ff
Version: 28.1
Firmware Version: SP6821a-Gonk-4.0-5-12