984243 - [Tarako]No response when clicking STK menus in some SIM cars

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Vendcom, defect)

Description

[sam.hua]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.22 (KHTML, like Gecko) Ubuntu Chromium/25.0.1364.160 Chrome/25.0.1364.160 Safari/537.22

Steps to reproduce:

insert a SIM from CMCC.
open ms.enter settings ->STK 
click some special menus.


Actual results:

There is no response when clicking some STK menus occasionally.(1/5)


Expected results:

pop up new menus.

Comment 1

[sam.hua]

logs:

D/RILC    (   96): [0118]> STK_SEND_ENVELOPE_COMMAND (D30782020181900104)
D/RIL     (   96): onRequest: STK_SEND_ENVELOPE_COMMAND sState=4
D/RIL     (   96): channel1 state: '0' 
D/RIL     (   96): get Channel ID '1'
D/AT      (   96): Channel1: AT> AT+SPUSATENVECMD="D30782020181900104"
D/AT      (   96): Channel1: AT< +SPUSATENVECMD: 0
D/AT      (   96): Channel1: AT< OK
D/RILC    (   96): [0118]< STK_SEND_ENVELOPE_COMMAND
D/RIL     (   96): put Channel ID '1'
I/RILC    (   96): -->CommandThread [347] free one command
D/AT      (   96): Channel0: AT< +SPUSATENDSESSIONIND
D/RIL     (   96): [stk unsl]RIL_UNSOL_STK_SESSION_END
D/RILC    (   96): [UNSL]< UNSOL_STK_SESSION_END 
E/GeckoConsole(  451): Content JS WARN at app://settings.gaiamobile.org/gaia_build_defer_index.js:6 in consoleWarn: [l10n] #undefined is undefined.
E/GeckoConsole(  451): Content JS WARN at app://settings.gaiamobile.org/gaia_build_defer_index.js:6 in consoleWarn: [l10n] #undefined is undefined.
E/GeckoConsole(  451): Content JS WARN at app://settings.gaiamobile.org/gaia_build_defer_index.js:6 in consoleWarn: [l10n] #undefined is undefined.
E/GeckoConsole(  451): Content JS WARN at app://settings.gaiamobile.org/gaia_build_defer_index.js:6 in consoleWarn: [l10n] #undefined is undefined.
E/GeckoConsole(  451): Content JS WARN at app://settings.gaiamobile.org/gaia_build_defer_index.js:6 in consoleWarn: [l10n] #undefined is undefined.
E/GeckoConsole(  451): Content JS WARN at app://settings.gaiamobile.org/gaia_build_defer_index.js:6 in consoleWarn: [l10n] #undefined is undefined.
E/GeckoConsole(  451): Content JS WARN at app://settings.gaiamobile.org/gaia_build_defer_index.js:6 in consoleWarn: [l10n] #undefined is undefined.
E/GeckoConsole(  451): Content JS WARN at app://settings.gaiamobile.org/gaia_build_defer_index.js:6 in consoleWarn: [l10n] #undefined is undefined.
E/GeckoConsole(  451): Content JS WARN at app://settings.gaiamobile.org/gaia_build_defer_index.js:6 in consoleWarn: [l10n] #undefined is undefined.
E/GeckoConsole(  451): Content JS WARN at app://settings.gaiamobile.org/gaia_build_defer_index.js:6 in consoleWarn: [l10n] #undefined is undefined.
E/GeckoConsole(  451): Content JS WARN at app://settings.gaiamobile.org/gaia_build_defer_index.js:6 in consoleWarn: [l10n] #undefined is undefined.
E/GeckoConsole(  451): Content JS WARN at app://settings.gaiamobile.org/gaia_build_defer_index.js:6 in consoleWarn: [l10n] #undefined is undefined.
E/GeckoConsole(  451): Content JS WARN at app://settings.gaiamobile.org/gaia_build_defer_index.js:6 in consoleWarn: [l10n] #undefined is undefined.
E/GeckoConsole(  451): Content JS WARN at app://settings.gaiamobile.org/gaia_build_defer_index.js:6 in consoleWarn: [l10n] #undefined is undefined.
E/GeckoConsole(  451): Content JS WARN at app://settings.gaiamobile.org/gaia_build_defer_index.js:6 in consoleWarn: [l10n] #undefined is undefined.

Comment 2

[Steven Yang [:styang]]

Hi Shawn, could you take a look on this? thanks!

Comment 3

[shawn ku [:sku]]

Hi Sam:
 Could you please enable gecko log by using below method, and attach the log for me to check?

// Enable gecko RIL realted log
1.1 adb pull /system/b2g/defaults/pref/user.js /tmp
1.2 Modify the value of ril.debugging.enabled to true.
      pref("ril.debugging.enabled", true);
1.3 adb remount
1.3 adb push /tmp/user.js /system/b2g/defaults/pref/
1.4 adb reboot

// Log command
adb logcat -v threadtime -b radio -b main > /tmp/test.log 

Thanks!!
Shawn

Comment 4

[sam.hua]

Attachment: 112.txt

bug logs.
no response for any sub stk menu

Comment 5

[sam.hua]

Hi, please check the log

Comment 6

[shawn ku [:sku]]

Hi Sam:
 It looks to me this is a card issue.

User select item by using STK_SEND_ENVELOPE_COMMAND (01 .. FF are all valid index). However, we saw a session end right after index=F1 item was selected.

That might be the root cause.
Please help me double check it on reference phone (AOSP version).

// Log
D/RILC    (   95): [0320]> STK_SEND_ENVELOPE_COMMAND (D307820201819001FF)
D/RILC    (   95): [0320]< STK_SEND_ENVELOPE_COMMAND
D/RILC    (   95): [0321]> STK_SEND_ENVELOPE_COMMAND (D3078202018190010B)
D/RILC    (   95): [0321]< STK_SEND_ENVELOPE_COMMAND
D/RILC    (   95): [0322]> STK_SEND_ENVELOPE_COMMAND (D30782020181900110)
D/RILC    (   95): [0322]< STK_SEND_ENVELOPE_COMMAND
D/RILC    (   95): [0323]> STK_SEND_ENVELOPE_COMMAND (D307820201819001F8)
D/RILC    (   95): [0323]< STK_SEND_ENVELOPE_COMMAND
D/RILC    (   95): [0324]> STK_SEND_ENVELOPE_COMMAND (D307820201819001F1)
D/RILC    (   95): [0324]< STK_SEND_ENVELOPE_COMMAND
D/AT      (   95): Channel0: AT< +SPUSATENDSESSIONIND
D/RIL     (   95): [stk unsl]RIL_UNSOL_STK_SESSION_END
D/RILC    (   95): [UNSL]< UNSOL_STK_SESSION_END

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

base on comment 6, minus for now, please renominate if comment 6 isn't true, thanks

Comment 8

[sam.hua]

OK,i will catch the modem log.

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I found that I had the same issue.  Granted that I used an expired SIM; Having said that, placing the SIM in a 1.3 Buri device, I can still navigate through the STK.

Gaia      63a7f183788218871c95a887328d091d58519edf
Gecko     https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/818e38fe5f4d
BuildID   20140321101803
Version   28.0
ro.build.version.incremental=86
ro.build.date=Thu Mar 20 11:25:47 CST 2014
Tarako

Comment 10

[James Zhang (Spreadtrum)]

Shawn will be here next week, let's fix it.
It's 1.3t+ bug.

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

ni? Shawn so he can clarify this with partner

Comment 12

[shawn ku [:sku]]

SPRD modem is clarifing issue now, will update bugzilla later.

Comment 13

[Joe Cheng [:jcheng] (please needinfo)]

let's wait for one more day

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Vendcom this bug since POVB.

Comment 15

[shawn ku [:sku]]

by refelecting to Vendor's bugzilla, there is no STR to repo. this issue.
Still checking with partner if this hit session timeout + takako performance issue!!

Comment 16

[shawn ku [:sku]]

Cannot repo this per partner's latest ROM/SIM.
Let's keep monitor this issue.

Comment 17

[shawn ku [:sku]]

Attachment: STK malfunction with CU SIM.

Comment 18

[shawn ku [:sku]]

Need gaia to check why there is no STK_SEND_TERMINAL_RESPONSE for below UNSOL_STK_PROACTIVE_COMMAND event.


01-02 03:25:08.770    92   216 D RILC    : [UNSL]< UNSOL_STK_PROACTIVE_COMMAND {D081868103012400820281828509807CBE54C163A883508F0A018053057F574E078C618F0A028065B095FB805A71268F0C03805E7D9ED851B77B118BDD8F0E04804E9252A85A314E50592751688F0C05808D225BCC76F4901A8F668F0A06809EBB8FA37F514E8B8F0A0780795D798F77ED4FE18F0A0880517B8EAB4FDD50658F08FF804E0B4E009875}
01-02 03:25:16.750    92   330 D RILC    : [0177]> STK_SEND_ENVELOPE_COMMAND (D30782020181900101)
01-02 03:25:16.990    92   332 D RILC    : [0178]> STK_SEND_ENVELOPE_COMMAND (D30782020181900101)
...
01-02 03:25:23.860    92   333 D RILC    : [0185]> STK_SEND_ENVELOPE_COMMAND (D30782020181900101)

Comment 19

[Evelyn Hung]

Can you work with Shawn to make sure Gaia working as we expected?

Comment 20

[Tzu-Lin Huang [:dwi2][:tzhuang]]

OK,

Shawn found an repro steps as follows:
1. Enter 3rd level STK menu
2. Click back button, Settings app will show 1st level STK menu then shift to 2nd level menu, click any item in 1st level menu BEFORE 2nd level menu show up 

In other device, step 2 only take very short time, but latency of step 2 is quite long on tarako which give us plenty of time to repro.

Comment 21

[Steven Yang [:styang]]

Not POVB

Comment 22

[Joe Cheng [:jcheng] (please needinfo)]

to Arthur

Comment 23

[Arthur Chen [:arthurcc][inactive after 6/30]]

https://github.com/mozilla-b2g/gaia/pull/18028

Fernando, I found the issue was fixed in master and I think it was due to the refactor work done along with the DSDS support. I tried to cherry-pick the related commits to v1.3t as the pull request. Could you help evaluate the risk of it?

Shawn, could you help test if the problem fixed with the pull request?

Thanks!

Comment 24

[[e-mail], [e-mail]]

Arthur, I'm able to reproduce the issue with your pr. It's easy to reproduce while I tap into settings::SIM1 STK menu.

My build version:

Gaia      d4f49ee421569bfc6e4cdaa3c0f9b5d91c677a3c
Gecko     https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/c2a0ee7b4d58
BuildID   20140407164002
Version   28.1
ro.build.version.incremental=eng.cltbld.20140407.202457
ro.build.date=Mon Apr  7 20:25:04 EDT 2014

====== kernel build version via "adb shell dump state" ======
Build: sp6821a_gonk-userdebug 4.0.4.0.4.0.4 OPENMASTER eng.cltbld.20140407.202457 test-keys

Comment 25

[shawn ku [:sku]]

clear ni? since Ian already apply PR, but still hit the issue.
(Anything need my help, please kindly ni? me again.)

Comment 26

[Arthur Chen [:arthurcc][inactive after 6/30]]

Clear ni? as uplifting the patch does not fix the issue.

Comment 27

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/18223

I'm not sure how to reproduce the issue exactly but I found sometimes the proactive command is waiting for response but somehow the main menu is displayed. So I extended the timeout to prevent the panel from navigated to the root panel so easily. And I also force to send a terminate command when displaying the main menu. Fernando, could you help check if this makes sense to you?

Comment 28

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Arthur Chen [:arthurcc] from comment #23)
> https://github.com/mozilla-b2g/gaia/pull/18028
> 
> Fernando, I found the issue was fixed in master and I think it was due to
> the refactor work done along with the DSDS support. I tried to cherry-pick
> the related commits to v1.3t as the pull request. Could you help evaluate
> the risk of it?
> 
> Shawn, could you help test if the problem fixed with the pull request?
> 
> Thanks!

Commented in GitHub.
We cann't merge directly since 1.3 didn't sent message object with iccId and command, only the command is received.

Comment 29

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Arthur Chen [:arthurcc] from comment #27)
> Created attachment 8405325 [details]
> Link to https://github.com/mozilla-b2g/gaia/pull/18223
> 
> I'm not sure how to reproduce the issue exactly but I found sometimes the
> proactive command is waiting for response but somehow the main menu is
> displayed. So I extended the timeout to prevent the panel from navigated to
> the root panel so easily. And I also force to send a terminate command when
> displaying the main menu. Fernando, could you help check if this makes sense
> to you?

Commented in github.

The timeout had been added by @gerard-majax, adding ni to him to get his opinion

Comment 30

[:gerard-majax]

I have no idea. STK is not something I know well.

Comment 31

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 8405325 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/18223

Check comments in github. I think this didn't work in 1.3

Comment 32

[Arthur Chen [:arthurcc][inactive after 6/30]]

Moving stkResTerminate() to the callback when timeout sounds good to me. As for the timeout value, as you suggested it is still too short for the target devices, every time I try to go back it always displays the root panel at first. Which UX designer should I ni? for re-evaluating the value?

Comment 33

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Arthur Chen [:arthurcc] from comment #32)
> Moving stkResTerminate() to the callback when timeout sounds good to me. As
> for the timeout value, as you suggested it is still too short for the target
> devices, every time I try to go back it always displays the root panel at
> first. Which UX designer should I ni? for re-evaluating the value?

[e-mail]

Comment 34

[Stephany Wilkes]

Flagging Omega on Settings and Carrie on the SIM and DSDS aspects (though I believe this is primarily about Settings).

Comment 35

[Joe Cheng [:jcheng] (please needinfo)]

triage: given that we are wrapping up tarako, this does not seem like an absolute blocker. put this to backlog base on the fact that STK isn't often used and this is happening 1/5 times.

Comment 36

[Omega Feng [:Omega] [:馮於懋]]

After discussion, 3-second timeout is acceptable.

Comment 37

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8405325 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/18223

Comment addressed, could you help check it again? Thanks!

Comment 38

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 8405325 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/18223

Looks good to me ;)

Comment 39

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8405325 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/18223

Evelyn, could you help review the patch?

The patch uses a longer timeout value to prevent users from being brought back to the root panel while navigating back. It also forces to send a terminate command when back to the root panel.

Comment 40

[sam.hua]

reproduced in v1.3 Tarako build (2014/04/16)

Comment 41

[[e-mail], [e-mail]]

After manual test, the patch is working for me.

Comment 42

[[e-mail], [e-mail]]

(In reply to Ian Liu [:ianliu] from comment #41)
> After manual test, the patch is working for me.

I mean the fixed patch in comment 39.

Comment 43

[Evelyn Hung]

Comment on attachment 8405325 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/18223

Thanks for the patch, and thank Ian for a test on device.

Comment 44

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3T+ to uplift

Comment 45

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks Fernando, Ian, and Evelyn!

v1.3T: 94ea80940466518a3d9b01245ae2dcd6d2597f2c