Closed Bug 984254 Opened 7 years ago Closed 7 years ago

CheckCaretDrawingState() probably shouldn't be NS_IMETHOD

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(1 file)

nsCaret.h currently has:
>  NS_IMETHOD CheckCaretDrawingState();

...while nsCaret.cpp has:
> nsresult nsCaret::CheckCaretDrawingState()

This method isn't declared in an idl file, so I think this wants to just be 'nsresult', not NS_IMETHOD.
Actually, this method only returns NS_OK, and none of the callers seem to check its return value, so it probably just wants to return void.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8392073 - Flags: review?(roc)
Attachment #8392073 - Attachment description: fix → fix: change return type to 'void'
https://hg.mozilla.org/mozilla-central/rev/d8e3558aeaa7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.