Closed
Bug 984265
Opened 12 years ago
Closed 12 years ago
JSHint fixes for shared/js
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gasolin, Assigned: gasolin)
Details
Attachments
(1 file)
JSHint all the things.
|
Assignee | |
Comment 1•12 years ago
|
||
Fix shared/js/*.js scripts warned by jshint.
Not dealing with `'param' is already defined issue`.
Attachment #8392161 -
Flags: review?(dflanagan)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 8392161 [details] [review]
pull request redirect to github
Since david's review queue is too long, re-flag review to tim
Attachment #8392161 -
Flags: review?(dflanagan) → review?(timdream)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 8392161 [details] [review]
pull request redirect to github
Looks good except the placement of `'use strict';` and `unused` options.
Attachment #8392161 -
Flags: review?(timdream) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/16612f797cbbc48ef292ec64a5f87ae75317a3e1
thanks!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•