984307 - [hamachi] Wrong screen and touch rotation problem in games

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Vendcom, defect)

Description

[mac]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20140212131424

Steps to reproduce:

1. Run game i.e. Slice Fruits


Actual results:

Everything in game is upside down - image and touch events.


Expected results:

It should be in right order to be able to play the game.

Comment 1

[mac]

The example of an issue:

http://www.youtube.com/watch?v=fZsmy7gCSxA&feature=youtu.be

Comment 2

[mac]

Found on:

Alcatel One Touch Fire production (got from T-mobile Poland)
B2G version: 1.4.0.0-prerelease master
Platform version: 30.0a1
Build Identifier: 20140316040201
Git commit info: 2014-03-15 11:08:47 70978988

Comment 3

[[:fabrice] Fabrice Desré]

Michael, it looks like we are not setting the screen orientation properly. Anything that rings a bell for you in gonk widgetry?

Comment 4

[u495161]

One of users has provided more info on this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=957756

Comment 5

[Michael Wu [:mwu]]

Does this work if hwc is turned off?

Comment 6

[mac]

Yes, it works properly when hwc was turned off. Device had been restarted after disabling hwc, before the test.

Comment 7

[Sushil]

I checked on b2g v1.3 reference ICS device but I do not see the issue with "Slice Fruits" game. Is it reported on b2g v1.3 or v1.4 ? Is it possible for you to test on b2g v1.3 once ?

Comment 8

[Sotaro Ikeda [:sotaro]]

It seems that the phone is flashed by "./flash.sh -f". I assume the problem does not happen if the phone was flashed correctly(update only gecko and gaia).

The problem typically happen when hamachi is flashed by "./flash.sh -f" and then show OpenGL rendered app in portrait mode. When content is rendered by OpenGL, the content is rendered by upside down. HwComposer need to handle it correctly. I know that hamachi's hw composer that built from b2g caf's source does not handle this situation correctly. But on hamachi, "./flash.sh -f" is not recommended. So, this should not be a problem.

Comment 9

[Sotaro Ikeda [:sotaro]]

I seems to understand the problem. In moz build, "TARGET_USES_MDP3" is not defined. Then the following code is not enabled. It causes the problem. By enabling the code, I confirmed the problem is fixed on master hamachi. But it happens only on moz build ROM and flash by './flash.sh -f'.

https://www.codeaurora.org/cgit/quic/la/platform/hardware/qcom/display/tree/libhwcomposer/a-family/hwcomposer.cpp?h=b2g_ics_1.2#n1559

Comment 10

[Sushil]

Yes, please enable this driver version flag in your build config. It is used in ICS based HAL.

Comment 11

[Sotaro Ikeda [:sotaro]]

"TARGET_USES_MDP3 := true" is defined under "ifeq ($(QC_PROP),true)". But it seems too late to enable all "ifeq ($(QC_PROP),true)". It might be better to add only "TARGET_USES_MDP3 := true" to moz build.

Comment 12

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add "TARGET_USES_MDP3 := true"

Confirmed the problem is fixed on master hamachi.

Comment 13

[Sotaro Ikeda [:sotaro]]

It seems better to change hamachi specific file. It is managed under mozilla-b2g. attachment 8392616 [details] [diff] [review] is not.

Comment 14

[Sotaro Ikeda [:sotaro]]

Attachment: patch v2 - Add "TARGET_USES_MDP3 := true"

Changed to hamachi specific file.

Comment 15

[Sotaro Ikeda [:sotaro]]

(In reply to mac from comment #2)
> Found on:
> 
> Alcatel One Touch Fire production (got from T-mobile Poland)
> B2G version: 1.4.0.0-prerelease master
> Platform version: 30.0a1
> Build Identifier: 20140316040201
> Git commit info: 2014-03-15 11:08:47 70978988

mac, how did you flashed your device? Is it using moz build rom or partner built rom?

Comment 16

[Sotaro Ikeda [:sotaro]]

Attachment: link to pull request

Comment 17

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8392869 [details]
link to pull request

mwu, can you review the pull request?

Comment 18

[mac]

(In reply to Sotaro Ikeda [:sotaro] from comment #15)
> (In reply to mac from comment #2)
> > Found on:
> > 
> > Alcatel One Touch Fire production (got from T-mobile Poland)
> > B2G version: 1.4.0.0-prerelease master
> > Platform version: 30.0a1
> > Build Identifier: 20140316040201
> > Git commit info: 2014-03-15 11:08:47 70978988
> 
> mac, how did you flashed your device? Is it using moz build rom or partner
> built rom?

The base was my own build:

OS Version: 1.4.0-prerelease
Build identifier: 20140308210648
Platform version: 30.0a1
Git info commit: 2014-03-08 10:15:36 efde3979

fastboot flash system and userdata with it.

Then I made several FOTAs up to the version I reported.

Comment 19

[Michael Wu [:mwu]]

Comment on attachment 8392869 [details]
link to pull request

Thanks!

Comment 20

[Sotaro Ikeda [:sotaro]]

https://github.com/mozilla-b2g/android-device-hamachi/commit/65569cd48bc7bf0817b4355a87ae221064a40678

Comment 21

[Sotaro Ikeda [:sotaro]]

> 
> The base was my own build:
> 
> OS Version: 1.4.0-prerelease
> Build identifier: 20140308210648
> Platform version: 30.0a1
> Git info commit: 2014-03-08 10:15:36 efde3979
> 
> fastboot flash system and userdata with it.

It updates hw composer hal implementation by own build.

Comment 22

[Sotaro Ikeda [:sotaro]]

I locally confirmed the problem is fixed.

Just "update source code & build" might not update the image correctly. It might be better to delete intermediate file under "./out" before built.

Comment 23

[mac]

Issue occurs again, tested on:

Alcatel One Touch Fire production (got from T-mobile Poland)
B2G version: 1.4.0.0-prerelease master
Platform version: 30.0a2
Build Identifier: 20140321000202
Git commit info: 2014-03-20 22:21:45 b09bf796

It worked well on exactly previous FOTA build with git info 2014-03-19 53edbf08

Comment 24

[u495161]

Bug confirmed on:

Alcatel One Touch Fire (T-mobile Poland)
B2G version: 1.4.0.0-prerelease master
Platform version: 30.0a2
Build Identifier: 20140323000204
Git commit info: 2014-03-22 00:39:53 73067095

and 

Build Identifier: 20140324000202
Git commit info: 2014-03-22 00:39:53 73067095

and

Build Identifier: 20140325000201
Git commit info: 2014-03-24 19:00:48 a2a88d06

Comment 25

[Sotaro Ikeda [:sotaro]]

(In reply to mac from comment #23)
> Issue occurs again, tested on:
> 
> Alcatel One Touch Fire production (got from T-mobile Poland)
> B2G version: 1.4.0.0-prerelease master
> Platform version: 30.0a2
> Build Identifier: 20140321000202
> Git commit info: 2014-03-20 22:21:45 b09bf796

It seems that the rom is v1.4. The change is applied only to master. To fix the problem need to apply to v1.4 branch. I am not sure this could get 1.4+ flag.

Comment 26

[Sotaro Ikeda [:sotaro]]

Set 1.4? flag. This is a moz build specific problem. This problem could affect to mozilla's product's evaluation.

Comment 27

[Jason Smith [:jsmith]]

QA Wanted - Can we reproduce this on the Moz side with the latest base image?

Comment 28

[Matthew Vaughan]

(In reply to Jason Smith [:jsmith] from comment #27)
> QA Wanted - Can we reproduce this on the Moz side with the latest base image?

This issue does *not* reproduce for me on the 03/26/14 1.4 build using the latest base image.

Device: Buri v1.4 MOZ RIL
BuildID: 20140326000201
Gaia: 7e705dd4718d528974d99ac31866318d7e201152
Gecko: 4889124accfa
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Comment 29

[Jason Smith [:jsmith]]

Okay - that implies this is a problem with an older base image being used here then, so this isn't a blocker.

Comment 30

[Sotaro Ikeda [:sotaro]]

From Comment 29, I unassign myself from this bug.

Comment 31

[mac]

Failed again, same issue. I've compiled current:

Alcatel One Touch Fire production (got from T-mobile Poland)
B2G version: 1.4.0.0-prerelease master
Platform version: 30.0a2
Build Identifier: 20140329183709
Git commit info: 2014-03-28 17:32:10 4c3b2f57

then flashed system and userdata from the build but same issue occurs again.

Then I've used FOTA to upgrade to:
Alcatel One Touch Fire production (got from T-mobile Poland)
B2G version: 1.4.0.0-prerelease master
Platform version: 30.0a2
Build Identifier: 20140329160202
Git commit info: 2014-03-28 17:32:10 4c3b2f57

with same result, issue occurs.

What is interesting, by mistake I've build 1.5.0 and flashed the device with system and userdata. On 1.5.0 it worked properly.

Comment 32

[mac]

I made also gaia-reset on:

Alcatel One Touch Fire production (got from T-mobile Poland)
B2G version: 1.4.0.0-prerelease master
Platform version: 30.0a2
Build Identifier: 20140329160202
Git commit info: 2014-03-28 17:32:10 4c3b2f57

but it still fails.

Comment 33

[mac]

Works on 2.0. Won't work on 1.4 as along as build will be done with default config (not taken from vendor).

Tested on:

Alcatel One Touch Fire production (got from T-mobile Poland)
B2G version: 2.0.0.0-prerelease master
Platform version: 32.0a1
Build Identifier: 20140608040204
Git commit info: 2014-06-07 03:42:38 2e5636e8