Closed Bug 984327 Opened 10 years ago Closed 10 years ago

B2G RIL: dun apn type is not included in isNetworkTypeSecondaryMobile(...)

Tracking

(blocking-b2g:1.4+, firefox29 wontfix, firefox30 fixed, firefox31 fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)

Status:

RESOLVED FIXED

Milestone:

1.4 S4 (28mar)

Project Flags:

blocking-b2g

1.4+

Tracking Flags:

Tracking

Status

firefox29

---

wontfix

firefox30

---

fixed

firefox31

---

fixed

b2g-v1.4

---

fixed

b2g-v2.0

---

fixed

People

(Reporter: jessica, Assigned: jessica)

References

Details

Attachments

(2 files, 3 obsolete files)

patch to include dun in isNetworkTypeSecondaryMobile(). 10 years ago Jessica Jong [:jessica] (inactive) 1.11 KB, patch		Details \| Diff \| Splinter Review
Part 1: include dun apn type in isNetworkTypeSecondaryMobile(...) and elsewhere. 10 years ago Jessica Jong [:jessica] (inactive) 3.38 KB, patch	vicamo : review+	Details \| Diff \| Splinter Review
Part 2: modify test cases for dun. 10 years ago Jessica Jong [:jessica] (inactive) 3.62 KB, patch	vicamo : review+	Details \| Diff \| Splinter Review
Part 1: include dun apn type in isNetworkTypeSecondaryMobile(...) and elsewhere. (final) 10 years ago Jessica Jong [:jessica] (inactive) 3.39 KB, patch	jessica : review+	Details \| Diff \| Splinter Review
Part 2: modify test cases for dun. (final) 10 years ago Jessica Jong [:jessica] (inactive) 3.63 KB, patch	jessica : review+	Details \| Diff \| Splinter Review

Jessica Jong [:jessica] (inactive)

Assignee

Description

•

10 years ago

I think this was left behind while rebasing. :(

Jessica Jong [:jessica] (inactive)

Assignee

Comment 1

•

10 years ago

Attached patch patch to include dun in isNetworkTypeSecondaryMobile(). (obsolete) — Details — Splinter Review

Jessica Jong [:jessica] (inactive)

Assignee

Comment 2

•

10 years ago

Will also add dun test in test_data_connection.js.

Ken Chang[:kenkai]

Comment 3

•

10 years ago

It is a 1.4+ issue.

blocking-b2g: --- → 1.4+

Vicamo Yang [:vicamo][:vyang]

Updated

•

10 years ago

Depends on: 960865

Jessica Jong [:jessica] (inactive)

Assignee

Comment 4

•

10 years ago

Attached patch Part 1: include dun apn type in isNetworkTypeSecondaryMobile(...) and elsewhere. (obsolete) — Details — Splinter Review

Attachment #8392144 - Attachment is obsolete: true

Jessica Jong [:jessica] (inactive)

Assignee

Comment 5

•

10 years ago

Attached patch Part 2: modify test cases for dun. (obsolete) — Details — Splinter Review

Jessica Jong [:jessica] (inactive)

Assignee

Comment 6

•

10 years ago

Comment on attachment 8392699 [details] [diff] [review]
Part 1: include dun apn type in isNetworkTypeSecondaryMobile(...) and elsewhere.

Sorry for missing these... :(

Attachment #8392699 - Flags: review?(vyang)

Jessica Jong [:jessica] (inactive)

Assignee

Updated

•

10 years ago

Attachment #8392700 - Flags: review?(vyang)

Vicamo Yang [:vicamo][:vyang]

Updated

•

10 years ago

Attachment #8392699 - Flags: review?(vyang) → review+

Vicamo Yang [:vicamo][:vyang]

Updated

•

10 years ago

Attachment #8392700 - Flags: review?(vyang) → review+

Jessica Jong [:jessica] (inactive)

Assignee

Comment 7

•

10 years ago

Try: https://tbpl.mozilla.org/?tree=Try&rev=56e6a28561cd

Jessica Jong [:jessica] (inactive)

Assignee

Comment 8

•

10 years ago

Attached patch Part 1: include dun apn type in isNetworkTypeSecondaryMobile(...) and elsewhere. (final) — Details — Splinter Review

Add r=vicamo.

Attachment #8392699 - Attachment is obsolete: true

Attachment #8393274 - Flags: review+

Jessica Jong [:jessica] (inactive)

Assignee

Comment 9

•

10 years ago

Attached patch Part 2: modify test cases for dun. (final) — Details — Splinter Review

Add r=vicamo.

Attachment #8392700 - Attachment is obsolete: true

Attachment #8393275 - Flags: review+

Jessica Jong [:jessica] (inactive)

Assignee

Comment 10

•

10 years ago

Ready to land on master, but there is still no official announcement for the process of uplifting to 1.4 branch.

Keywords: checkin-needed

Ryan VanderMeulen [:RyanVM]

Comment 11

•

10 years ago

(In reply to Jessica Jong [:jjong] [:jessica] from comment #10)
> Ready to land on master, but there is still no official announcement for the
> process of uplifting to 1.4 branch.

Sure there is, see dev-b2g (or go directly to the source - https://wiki.mozilla.org/Release_Management/B2G_Landing#v1.4.0).

Ryan VanderMeulen [:RyanVM]

Comment 12

•

10 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/9aad5fa96f9f
https://hg.mozilla.org/integration/b2g-inbound/rev/e7b54cb288fa

Flags: in-testsuite+

Keywords: checkin-needed

Carsten Book [:Tomcat]

Comment 13

•

10 years ago

https://hg.mozilla.org/mozilla-central/rev/9aad5fa96f9f
https://hg.mozilla.org/mozilla-central/rev/e7b54cb288fa

Status: NEW → RESOLVED

Closed: 10 years ago

Resolution: --- → FIXED

Ryan VanderMeulen [:RyanVM]

Comment 14

•

10 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/03e04f7d561a
https://hg.mozilla.org/releases/mozilla-aurora/rev/7568d39b81c5

status-b2g-v1.4: --- → fixed

status-b2g-v2.0: --- → fixed

status-firefox29: --- → wontfix

status-firefox30: --- → fixed

status-firefox31: --- → fixed

Target Milestone: --- → 1.4 S4 (28mar)

You need to log in before you can comment on or make changes to this bug.