984328 - [Keyboard][V1.3T] The alternative char menu cannot be displayed

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[William Hsu [:whsu]]

Attachment: WP_20140317_023.mp4

* Description:
  This problem happened on v1.3T build, and cannot reproduce it on V1.4 build.
  After tap and hold a letter on the keyboard, the the action chain cannot be displayed.
  Attaching the demo video. (WP_20140317_023.mp4)

* Reproduction steps:
  1. Launch the browser app.
  2. Tap the URL bar
  3. Tap and hold on any letter on the keyboard.

* Expected result:
  The action chain can be displayed

* Actual result:
  The action chain cannot be displayed

* Reproduction build:(Tarako Build)
  - Gaia      15385efaf840090391d182d821eaeda6d25cf0e0
  - Gecko     NA
  - BuildID   20140317060055
  - Version   28.0


Thanks!

Comment 1

[John Hammink]

Thanks for showing this on both builds for context.  Is it possible that due to extremely low memory on Tarako that this might be intended behavior?  Not sure.

Comment 2

[William Hsu [:whsu]]

It  might relate to memory usage.

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: logcat.txt

I can only reproduce this with memory pressure : 
03-24 15:31:43.960: E/GeckoConsole(81): [JavaScript Warning: "Error in parsing value for 'font-size'.  Declaration dropped." {file: "app://keyboard.gaiamobile.org/index.html#en" line: 0 column: 0 source: "-0.03125px"}]
03-24 15:31:43.960: E/GeckoConsole(81): [JavaScript Warning: "Error in parsing value for 'width'.  Declaration dropped." {file: "app://keyboard.gaiamobile.org/index.html#en" line: 0 column: 0 source: "-1px"}]

Also : 
APPLICATION      USER     PID   PPID  VSIZE  RSS     WCHAN    PC         NAME
b2g              root      81    1     148524 26016 ffffffff 40100724 R /system/b2g/b2g
(Nuwa)           root      351   81    51832  484   ffffffff 4014f518 S /system/b2g/plugin-container

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I used Tarako build : 
Gaia      8132b88334f61288060a2680857c54c7af82cdc5
Gecko     57625761da9e5c35d1ddd516221ce274a3575d15
BuildID   20140324121117
Version   28.0
ro.build.version.incremental=87
ro.build.date=Fri Mar 21 08:01:31 CST 2014

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

hi Rudy, can you take an initial look at this? thanks

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I'll take a look.

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I could not reproduce this issue with the follow build,
======
Gaia      8132b88334f61288060a2680857c54c7af82cdc5
Gecko     57625761da9e5c35d1ddd516221ce274a3575d15
BuildID   20140325060053
Version   28.0
ro.build.version.incremental=121
ro.build.date=Tue Mar 25 06:09:04 CST 2014

--
I've done the following things to increase the memory usage:
 1. Play music in the background. 
 2. Or do edit picture and save, then go back to browser app.

William,

As our discussion, if you could reproduce this issue with current build, please help let me know.
Thanks.

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Gaia      f6a7afd0d716f7a38dfc1808ee0aab3e06ba2f1d
Gecko     fb7149d9b320d939d716011f865ec34661ebc353
BuildID   20140326061134
Version   28.1
ro.build.version.incremental=68
ro.build.date=Wed Mar 26 06:17:50 CST 2014
Tarako

I am able to reproduce this issue with today's build.  I placed the device under memory pressure by editing several images and then immediately closing the app, launching browser and hold the A key down.  The A shows briefly and then should disappear and show multiple accented "A"s, but does not.  Instead in the logcat I get the following: 
03-26 19:43:28.140: E/GeckoConsole(81): [JavaScript Warning: "Error in parsing value for 'width'.  Declaration dropped." {file: "app://keyboard.gaiamobile.org/index.html#en" line: 0 column: 0 source: "-1px"}]

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Naoki,

Thanks for the advice in comment 8, now I could reproduce this issue after editing an image several times.

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1 - pull request 17687

This patch is to resolve this issue that after memory pressure and the keyboard frame is removed, IMERender would not get resize event to initialize its cached window height/width correctly, which may cause several UI issues like this one.

Tim,

Could you help review this?
Thank you.

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

triage: since tarako may be released into different markets, should fix this keyboard bug for tarako

Comment 13

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8397622 [details] [review]
Patch V1 - pull request 17687

Not sure if v1.3T+ needs to ask for approval for Gaia v1.4, but I'll just comment here anyway.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): should be Bug 957880 and Bug 972276.
[User impact] if declined: Some functions of the keyboard would have defects, like alternative char menu and suggestion panel after memory pressure.
Though, this could be workaround-ed, if the user dismiss and relaunch the keyboard.
[Testing completed]: Yes, manually.
[Risk to taking this patch] (and alternatives if risky): Should be low, only to correctly init the cached window width and height.
[String changes made]: N/A.

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Why not land master?

Comment 15

[[:fabrice] Fabrice Desré]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #14)
> Why not land master?

Yes, that should land on master and be uplifted. We don't want 1.3T-only patches in general.

Comment 16

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Yes, the pull request to master is on the way,
https://github.com/mozilla-b2g/gaia/pull/17737

This was not landed yesterday because Gaia master was busted.

Comment 17

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Gaia master,
https://github.com/mozilla-b2g/gaia/commit/4de40c81d8ee8a445c0634dd849c1c54009c7a97

v1.3t,
https://github.com/mozilla-b2g/gaia/commit/6c3dc374b6af2b2487051e8aedad0c4a49ebd3dd

Comment 18

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

v1.4,
c560abafb1e169dfd1cf2f73f7dc1fa7a5458db7

Comment 19

[William Hsu [:whsu]]

Verified it. Thanks for the help!

* Build Information:
 - Gaia      02b97c89dec7a10a955c85b921b2a66181eebb0e
 - Gecko     f8bca24057937f5b09d73512ba1e771011ab4203
 - BuildID   20140331124355
 - Version   28.1