Closed Bug 984338 Opened 6 years ago Closed 6 years ago

Add an pref to flash layer borders when they are created

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: nical, Assigned: nical)

Details

Attachments

(1 file, 1 obsolete file)

This will make it easier to see if layers are frequently recreated. Paint flashing already can already show some of the symptoms of creating/destroying layers too often, but paint flashing also shows when an already existing layer is just invalidated and repainted so it only gives hints that the layer may be recreated.
This patch adds the pref "layers.flash-borders" that makes layer border colors fade from black to their normal color in ~2s when they are created. Note that it also forces full-tilt compositing when the pref is set.
Attachment #8392163 - Flags: review?(jmuizelaar)
The previous patch had the pref set to true by default instead of false.
Attachment #8392163 - Attachment is obsolete: true
Attachment #8392163 - Flags: review?(jmuizelaar)
Attachment #8392219 - Flags: review?(jmuizelaar)
This is great. Thanks.
Comment on attachment 8392219 [details] [diff] [review]
flash layer borders when they are created

Review of attachment 8392219 [details] [diff] [review]:
-----------------------------------------------------------------

Would it be better to use a timestamp instead of a composite count?
(In reply to Jeff Muizelaar [:jrmuizel] from comment #4)
> Comment on attachment 8392219 [details] [diff] [review]
> flash layer borders when they are created
> 
> Review of attachment 8392219 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Would it be better to use a timestamp instead of a composite count?

I have never used timestamps in Gecko so I don't know if it's practical to use. My preference will go to the simplest implementation. Composite count works fine because it doesn't matter much if the transition takes 2 or 2.1 seconds.
Attachment #8392219 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/cc6d4225d091
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.