Closed
Bug 984379
Opened 8 years ago
Closed 8 years ago
crashes [NS_ABORT_OOM(unsigned int) | nsAString_internal::Assign(wchar_t const*, unsigned int] because of loading streaming videos
Categories
(Core :: Internationalization, defect)
Tracking
()
VERIFIED
FIXED
mozilla31
People
(Reporter: suburp212, Assigned: m_kato)
Details
(Keywords: crash, Whiteboard: [bugday-20140317])
Crash Data
Attachments
(1 file)
2.03 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release) Build ID: 20140212131424 Steps to reproduce: I loaded two parallel youtube videos Actual results: firefox crashed, crash reporter appeared (https://crash-stats.mozilla.com/report/index/cba10729-8d3d-4fde-a57f-9e6ec2140302) Expected results: loaded normally
Crash Signature: NS_ABORT_OOM(unsigned int) | nsAString_internal::Assign(wchar_t const*, unsigned int)
Crash Signature: NS_ABORT_OOM(unsigned int) | nsAString_internal::Assign(wchar_t const*, unsigned int) → [@ NS_ABORT_OOM(unsigned int) | nsAString_internal::Assign(wchar_t const*, unsigned int) ]
Keywords: crash
![]() |
||
Updated•8 years ago
|
Severity: normal → critical
Whiteboard: [bugday-20140317]
Assignee | ||
Comment 1•8 years ago
|
||
nsScriptableUnicodeConverter should use fallible_t.
Status: UNCONFIRMED → NEW
Component: Untriaged → Internationalization
Ever confirmed: true
Product: Firefox → Core
Assignee | ||
Comment 2•8 years ago
|
||
Assignee: nobody → m_kato
Attachment #8397039 -
Flags: review?(smontagu)
Updated•8 years ago
|
Attachment #8397039 -
Flags: review?(smontagu) → review+
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8ecf1ba4139
Target Milestone: --- → mozilla31
Comment 4•8 years ago
|
||
Comment on attachment 8397039 [details] [diff] [review] Fix > // No Adopt on nsACString :( >- _retval.Assign(str, len); >+ if (!_retval.Assign(str, len, mozilla::fallible_t())) { >+ rv = NS_ERROR_OUT_OF_MEMORY; >+ } > moz_free(str); The comment lies! It probably predates the "latest" string API overhaul. _retVal.Adopt(str, len) should be fine.
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to neil@parkwaycc.co.uk from comment #4) > Comment on attachment 8397039 [details] [diff] [review] > Fix > > > // No Adopt on nsACString :( > >- _retval.Assign(str, len); > >+ if (!_retval.Assign(str, len, mozilla::fallible_t())) { > >+ rv = NS_ERROR_OUT_OF_MEMORY; > >+ } > > moz_free(str); > The comment lies! It probably predates the "latest" string API overhaul. > _retVal.Adopt(str, len) should be fine. really? This issue will continue to bug 989835.
Comment 6•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c8ecf1ba4139
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Suburp, can you confirm the latest Nightly no longer crashes for you?
status-firefox28:
--- → wontfix
status-firefox29:
--- → affected
status-firefox30:
--- → affected
status-firefox31:
--- → fixed
Flags: needinfo?(suburp212)
I'm still seeing two crashes with this signature post-fix. Firefox 31 2014-04-09: https://crash-stats.mozilla.com/report/index/c1960493-8b08-44fb-811c-e6f592140410 Firefox 31 2014-04-12: https://crash-stats.mozilla.com/report/index/95729cf6-3de5-4270-9e42-5476f2140414 Should this bug get reopened?
Comment 9•8 years ago
|
||
There is a user that was experiencing this in the forums for 30-31 [https://support.mozilla.org/en-US/questions/994049] Firefox is hanging or crashing. There are some screenshots in the thread as well.
Comment 10•8 years ago
|
||
i had yesterday a crashe linked to this report in Firefox 33. Therfore it seems to be not fixed :(
Comment 11•8 years ago
|
||
https://crash-stats.mozilla.com/report/index/d5e42902-5280-4f53-8b92-799d92140613
Comment 12•8 years ago
|
||
(In reply to lars.gusowski+bugzilla from comment #11) > https://crash-stats.mozilla.com/report/index/d5e42902-5280-4f53-8b92- > 799d92140613 Thanks for sharing your report, Lars. You might be getting a different crash with the same signature, your stack looks different than what was originally reported here. I'll leave it to the developers on this bug to determine if this bug report should be reopened or if you should file a new bug report.
m_kato, can you look at lars's crash from comment 11? Do you think this is a different crash with the same signature? We have several new reports with the same signature: https://crash-stats.mozilla.com/query/?product=Firefox&version=Firefox%3A31.0b&range_value=1&range_unit=weeks&date=06%2F19%2F2014+22%3A00%3A00&query_search=signature&query_type=contains&query=NS_ABORT_OOM%28unsigned+int%29+|+nsAString_internal%3A%3AAssign%28wchar_t+const*%2C+unsigned+int&reason=&release_channels=&build_id=&process_type=any&hang_type=any Thanks!
Flags: needinfo?(m_kato)
Assignee | ||
Comment 14•8 years ago
|
||
(In reply to Liz Henry :lizzard from comment #13) > m_kato, can you look at lars's crash from comment 11? Do you think this is > a different crash with the same signature? We have several new reports with > the same signature: > > https://crash-stats.mozilla.com/query/?product=Firefox&version=Firefox%3A31. > 0b&range_value=1&range_unit=weeks&date=06%2F19%2F2014+22%3A00%3A00&query_sear > ch=signature&query_type=contains&query=NS_ABORT_OOM%28unsigned+int%29+|+nsASt > ring_internal%3A%3AAssign%28wchar_t+const*%2C+unsigned+int&reason=&release_ch > annels=&build_id=&process_type=any&hang_type=any > > Thanks! It is different. I think we should add nsAString_internal::Assign to skiplist of crash reporter.
Flags: needinfo?(m_kato)
Assignee | ||
Comment 15•8 years ago
|
||
filed as bug 1033883 for skiplist request.
Reporter | ||
Comment 16•8 years ago
|
||
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #7) > Suburp, can you confirm the latest Nightly no longer crashes for you? I couldn't reproduce the crash on the 31, but that doesn't mean it's fixed permanently, as these other comments suggest.
Flags: needinfo?(suburp212)
Comment 17•8 years ago
|
||
(In reply to Suburp from comment #16) > (In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #7) > > Suburp, can you confirm the latest Nightly no longer crashes for you? > > I couldn't reproduce the crash on the 31, but that doesn't mean it's fixed > permanently, as these other comments suggest. Thanks for checking. The other comments will be addressed in a follow-up bug. Marking this verified fixed.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•