Closed Bug 984407 Opened 10 years ago Closed 10 years ago

Activating 'I'm thinking of...' creates 8 reflows on enter, 10 on exit

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: janjongboom, Assigned: janjongboom)

References

Details

Attachments

(1 file, 1 obsolete file)

46 bytes, text/x-github-pull-request
ranbena
: review+
janjongboom
: feedback+
Details | Review
Click on the e.me bar. 8 reflows happen (from a Keon, running master):

reflow: 0.24ms function scrollTo, Scroll.js line 78
reflow: 1.7ms function scrollTo, Scroll.js line 78
reflow: 3.63ms
reflow: 13.68ms
reflow: 0.37ms
reflow: 6.74ms
reflow: 7.86ms
reflow: 0.99ms

When you go out of it it creates even more:

reflow: 3.06ms
reflow: 1.36ms
reflow: 6.7ms
reflow: 2.8ms
reflow: 1.54ms
reflow: 0.27ms
reflow: 5.93ms
reflow: 7.1ms
reflow: 4.01ms
reflow: 1.44ms
Blocks: 984408
Component: Gaia::Homescreen → Gaia::Everything.me
Attached file Patch for some of them (obsolete) —
This fixes a bunch of reflows. Most important I think is the sync reflow that we had in Scroll.js.

Four of the reflows (in both focus as well as blur) were related to the window getting bigger/smaller because the keyboard pops in, can't really help it. Fixed one (https://github.com/comoyo/gaia/commit/c6faab65be810f36cd4ebc96e507075adf02068d).

The reflows that are left are related to https://github.com/mozilla-b2g/gaia/pull/17295/files#diff-6e87524c31484e2e2128b007057a8b28R68, but don't dare to change that :-)

A big one was https://github.com/comoyo/gaia/commit/e8f0a23e841e6c7a3caf9c86308b25ccf34a853e, because at the moment we're animating the min-height property, and now it's transform. So it's a lot smoother.

There is still lot of slowness on first time you activate the e.me bar (15 reflows or so) but that code is so hairy and probably obsolete with rocketbar that I don't touch it.

As far as I can see there are no visual differences
Attachment #8393005 - Flags: review?(crdlc)
Comment on attachment 8393005 [details] [review]
Patch for some of them

LGTM the homescreen part. I would like that Ran will review it as ev.me's owner. Good job Jan
Attachment #8393005 - Flags: review?(ran)
Attachment #8393005 - Flags: review?(crdlc)
Attachment #8393005 - Flags: feedback+
Hey Jan, great work. I put a few comments on github.
Attached file Patch v2
Carrying over f+ from crdlc.

See comments on GH again. FYI, moved this over to another PR.
Attachment #8393005 - Attachment is obsolete: true
Attachment #8393005 - Flags: review?(ran)
Attachment #8393657 - Flags: review?(ran)
Attachment #8393657 - Flags: feedback+
Comment on attachment 8393657 [details] [review]
Patch v2

Works well.
(Though I have to say I am uneasy with the pointer-events hack)
Attachment #8393657 - Flags: review?(ran) → review+
https://github.com/mozilla-b2g/gaia/commit/8ccc4fdfdc0404e61bf238a55d63f8cb277ae205
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: