Closed Bug 984484 Opened 10 years ago Closed 10 years ago

Convert GetMarkerPositioningData form gfxPoint to Moz2D

Categories

(Core :: SVG, defect)

29 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

      No description provided.
Attached patch patchSplinter Review
Attachment #8392324 - Flags: review?(cam)
Comment on attachment 8392324 [details] [diff] [review]
patch

Review of attachment 8392324 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/SVGPathData.cpp
@@ +820,5 @@
>    return BuildPath(FillRule::FILL_WINDING, NS_STYLE_STROKE_LINECAP_BUTT, 0);
>  }
>  
>  static double
> +AngleOfVector(const Point& aVector)

I guess eventually this one will go away and we'll only have a float version.

@@ +860,5 @@
>  
>      // info on current segment:
>      uint16_t segType =
>        SVGPathSegUtils::DecodeType(mData[i++]); // advances i to args
> +    Point &segStart = prevSegEnd;

While touching this line please move the "&" next to the type.

@@ +908,4 @@
>        } else {
> +        cp1 = segStart + Point(mData[i],   mData[i+1]);
> +        cp2 = segStart + Point(mData[i+2], mData[i+3]);
> +        segEnd = segStart + Point(mData[i+4], mData[i+5]);

Fix up the spaces in the Point() argument lists in these and later ones in the file.
Attachment #8392324 - Flags: review?(cam) → review+
https://hg.mozilla.org/mozilla-central/rev/fbe3a1cc2a96
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: