984530 - Bing search tags are not working properly

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mike Connor [:mconnor]]

In looking into the Yahoo report (bug 983723) it looks like Bing is just plain broken on 27/28 (haven't looked into older bugs).  The plugin is set up to only send codes if the engine is default, but even if that's correct it's not working.  It's also using the desktop codes, rather than the codes for Firefox for Android.  I believe, and I'm waiting for Joanne to confirm, that we should be sending the codes at _least_ for all beta/official searches, and potentially for all channels.  The patch should be straightforward once we've decided exactly what it needs to do.

Comment 1

[Mike Connor [:mconnor]]

Attachment: bingSearchCodes

These codes are not branch-specific, and not position-specific.  Making use of tablet vs. mobile because those tags are different.

Comment 2

[Mike Connor [:mconnor]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4846a0ac4a50

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4846a0ac4a50

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 8401626 [details] [diff] [review]
bingSearchCodes

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 903084
User impact if declined: missing rev credit for Bing
Testing completed (on m-c, etc.): baking for a while
Risk to taking this patch (and alternatives if risky): it's not working now, it won't change much
String or IDL/UUID changes made by this patch: none

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8401626 [details] [diff] [review]
bingSearchCodes

Approving because it is a small change.

Comment 6

[Flaviu Cos]

The bing search is no longer present in the default search engines.
Logged bug 997179 for this issue.
Tested on Nightly 31.0a1 (2014-04-16) using Google Nexus 7 (Android 4.4.2).

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/aa841fec9c84
https://hg.mozilla.org/releases/mozilla-beta/rev/148684fea6d4