984684 - Do not fire post barriers on shared atoms from workers

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: do_not_barrier_shared_atoms-v0.diff

We are currently falling on many tests on maple because we are hitting an assertion: CurrentThreadOwnsRuntime(cell->runtime()). It turns out these |cell| are all coming from shared atoms. This patch copies the test we are currently doing for pre-barriers to the JS::Heap post-barrier.

This is potentially an issue for the in-engine barriers too as they also see shared atoms. They do not, however, have workers that implement barriers, so this doesn't matter. If we do ever have invalid off-thread usage at some point, the same assertions will catch that usage; for now I'm just going to leave our in-engine barriers alone.

Comment 1

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/405082f9ce44

Comment 2

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/405082f9ce44

Comment 3

[Terrence Cole [:terrence]]

I am dumb and only fixed case that was hit. We also need the non-relocate case.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5c54354e723

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e5c54354e723