984792 - Task manager doesn't take direction or extent of drag into account

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Chris Lord [:cwiiis]]

When bringing up the task switcher, it seems it's quite a distance your finger has to travel before it responds to the input - it feels very unnatural. It also very frequently mistakes a drag for a selection.

This is contrary to the home screen, which for the most part is ok, or indeed the kinetic scrolling available in all apps that responds quickly and feels very immediate.

Comment 1

[Chris Lord [:cwiiis]]

Ok, I just tried the latest and it's *much* better! There's still a big jump when you start dragging an app upwards, and there's still some oddness where if you start dragging in a direction, the carousel will always move in that direction, even if you let go very close to the original app or even start dragging back towards that app.

To be clear, there are two remaining problems:

- Dragging an app upwards to close it has a large 'dead' area where it thinks you're dragging horizontally and does nothing, but once you get past this point, the app 'jumps' to the new position.
- Dragging an app horizontally will always cause the carousel to animate to the next app, even if you switch drag directions or let go very close to the original app.

Should I track these in two separate bugs, or is this bug adequate?

Comment 2

[Chris Lord [:cwiiis]]

Only the second problem in comment #1 still remains, so I'll change this bug to track that and take it on.

Comment 3

[Chris Lord [:cwiiis]]

Attachment: Take direction into account when dragging cards in task manager

If the user changes their scroll direction while dragging and moves past the card-switching threshold, this tracks that and will change the direction the card will move. This allows you to peek to the left/right of a card, and just to generally play around in the task manager and have it feel natural.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Dupe of 1031287?

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8447244 [details] [review]
Take direction into account when dragging cards in task manager

Did you paste the wrong pr? it's the same as bug 1031287

Comment 6

[Chris Lord [:cwiiis]]

Attachment: Take direction into account when dragging cards in task manager

Fixed linting issues and rebased.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8448565 [details] [review]
Take direction into account when dragging cards in task manager

Please request review again with tests, thanks!

Comment 8

[Chris Lord [:cwiiis]]

Comment on attachment 8448565 [details] [review]
Take direction into account when dragging cards in task manager

Updated with a test. This pull-request is based on top of bug 1031287 as otherwise they'll be nasty conflicts when merging them.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8448565 [details] [review]
Take direction into account when dragging cards in task manager

I recommend to wait your another fix is in master and rebase again to land.
And I am requesting ui review to confirm it's wanted.

Comment 10

[Stephany Wilkes]

Comment on attachment 8448565 [details] [review]
Take direction into account when dragging cards in task manager

Flagging Francis to do this ui-review?.

Comment 11

[Francis Djabri [:djabber]]

Comment on attachment 8448565 [details] [review]
Take direction into account when dragging cards in task manager

It's working well for me - great work!

Comment 12

[Carsten Book [:Tomcat]]

travis build failed https://travis-ci.org/mozilla-b2g/gaia/builds/28898334 is this related to this patch ?

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Carsten Book [:Tomcat] from comment #12)
> travis build failed https://travis-ci.org/mozilla-b2g/gaia/builds/28898334
> is this related to this patch ?

Thanks for reminding!

Comment 14

[Chris Lord [:cwiiis]]

I just rebased and pushed fixes for the linting errors, I'll merge if the tests come back successful.

Comment 15

[Chris Lord [:cwiiis]]

Tests green, merged to master: https://github.com/mozilla-b2g/gaia/commit/1d1d9a6ca0c9c2d1eb04d874d631fca189ecc839

Comment 16

[Chris Lord [:cwiiis]]

Francis, do we want this in 2.0? I don't think there's much risk, but it isn't a very small patch.

Comment 17

[Francis Djabri [:djabber]]

From a UX point of view, it would be great to get this in for 2.0. From a risk perspective for the stability of the product, I'm not the best person to ask.

Comment 18

[Chris Lord [:cwiiis]]

Comment on attachment 8448565 [details] [review]
Take direction into account when dragging cards in task manager

Seeking approval based on comment #17.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): This bug
[User impact] if declined: Task manager is slightly more awkward than necessary
[Testing completed]: Been on master for a few days, tested locally, tested via integration tests
[Risk to taking this patch] (and alternatives if risky): Small risk of regressing task manager behaviour somehow (all tests pass however, and manual testing shows up no obvious problems)
[String changes made]: None

Comment 19

[bhavana bajaj [:bajaj]]

Comment on attachment 8448565 [details] [review]
Take direction into account when dragging cards in task manager

Approving to improve the experience here, if this has regressions/serious fallouts we should back it out immediately.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/c82319643349a7ab4cf9b9f4936bc8d7f0e3c7c5