98480 - Save button stays disabled if filepicker is raised but not focused

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

Build ID:  2001-09-05-21, RedHat 7.1 with Ximian/GNOME.

Summary:  Save button disabled until I focus the textfield.

Steps to Reproduce:

1.  Click on:
ftp://ftp.mozilla.org/pub/mozilla/nightly/2001-09-05-21-trunk/mozilla-i686-pc-linux-gnu-installer.tar.gz


2.  When you get the Open/Save dialog, choose "Save this file to Disk".
3.  Look at the state of the save button.

Expected Results:

The save button is enabled, since I've got
"mozilla-i686-pc-linux-gnu-installer.tar.gz" passed in from the dialog in step #2.

Actual Results:

Until I focus anywhere in the dialog (be it the titlebar, scrollbar, etc), the
save button remains disabled.

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

on irc, bryner claimed this.

Comment 2

[Brian Ryner (not reading)]

Trying to clarify summary...

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

*** Bug 99973 has been marked as a duplicate of this bug. ***

Comment 4

[Brian Ryner (not reading)]

*** Bug 100442 has been marked as a duplicate of this bug. ***

Comment 5

[sairuh (rarely reading bugmail)]

spam: over to File Handling. i have not changed the assigned developer [or the
other fields for that matter], so if anyone realizes that a bug should have a
more appropriate owner, go ahead and change it. :)

Comment 6

[Uwe Siems]

Same with Save Image/Save Link As in the context menu of a page. The save button
gets enabled when the dialog gets focus. But it is disabled again, when you e.g.
scroll the file list, and enabled again, when you double click a directory to
save the file in.

Comment 7

[Brian Ryner (not reading)]

*** Bug 108009 has been marked as a duplicate of this bug. ***

Comment 8

[Preston Crow]

From bug 108009:  With twm as the window manager, the situation is a bit worse
in that the window fails to get the focus when it should.  This is related to
bug 78928 and it may be that the root cause here is that the file picker is
expecting to receive X events that it is not getting (either due to the window
manager behaving differently than expected or due to having the wrong
expectations altogether).

Comment 9

[Brian Ryner (not reading)]

Attachment: patch

This fixes both problems reported here (the button erroneously disabling when
you focus the file list, even if there is text in the filename field), and the
button not enabling when the window first appears.  It doesn't address the
problem that modal dialogs opened from other modal dialogs aren't focused for
some reason.

Comment 10

[sairuh (rarely reading bugmail)]

*** Bug 109625 has been marked as a duplicate of this bug. ***

Comment 11

[Brian Ryner (not reading)]

r=jag (from bryner's machine)

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 57406 [details] [diff] [review]
patch

sr=[e-mail]

Comment 13

[Brian Ryner (not reading)]

checked in

Comment 14

[sairuh (rarely reading bugmail)]

vrfy fixed: 2001.11.27.12-comm bits on rh7.2.