Closed Bug 984801 Opened 10 years ago Closed 10 years ago

[MADAI][CostControl] @2.25x assets update for CostControl

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Cost Control
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: HHuang, Assigned: mai)

References

Details

Attachments

(2 files, 1 obsolete file)

CostControl@2.25x.zip
64.18 KB, application/zip
Details
patch v1.0
46 bytes, text/x-github-pull-request
arnau
: review+
Details | Review
Attached file CostControl@2.25x.zip (obsolete) — 
Assets update.
Blocks: 983069
Hi, 
  Do you mind reviewing the following items:
 
- Missing pictures:
  * next@2.25x.png  (apps/costcontrol/style/images/app/icons/)
  * prev@2.25x.png  (apps/costcontrol/style/images/app/icons/)

- Check the color of the config.png  button. Currently it's blue not grey (apps/costcontrol/style/images/app/icons/).

Regards
Flags: needinfo?(hhuang)
Attached file CostControl@2.25x.zip — 
Hi marina, 

Sorry for the late reply.
The missing pictures are already updated, please check the attached.

Besides, following the latest header style, the buttons on the left hand side of the header should be blue/orange, and grey/white buttons on the right side. So that config button should be grey now.
Attachment #8392778 - Attachment is obsolete: true
Flags: needinfo?(hhuang)
Assignee: nobody → mri
Attached file patch v1.0 — 
Arnau, could you review the patch?
Attachment #8396375 - Flags: review?(arnau)
Comment on attachment 8396375 [details] [review]
patch v1.0

Sorry for the delay in the review. LGTM
Attachment #8396375 - Flags: review?(arnau) → review+
Master: fef90dc9944dbd1601e1f1051911562067a19043
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
A quick heads up, the images that were merged as part of this bug haven't been properly re-compressed before inclusion. Please do so here or in a follow-up as it yields significant savings. You can recompress the images with the following command from gaia's root directory:

./tools/png_recompress.sh -v \
    apps/costcontrol/style/images/app/icons/config@2.25x.png \
    apps/costcontrol/style/images/app/icons/next@2.25x.png \
    apps/costcontrol/style/images/app/icons/prev@2.25x.png \
    apps/costcontrol/style/images/app/icons/reload@2.25x.png \
    apps/costcontrol/style/images/app/icons/topup@2.25x.png \
    apps/costcontrol/style/images/app/icons/topupcode@2.25x.png \
    apps/costcontrol/style/images/app/icons/warning@2.25x.png \
    apps/costcontrol/style/images/widget/icons/icon-go@2.25x.png \
    apps/costcontrol/style/images/widget/icons/updating@2.25x.png \
    apps/costcontrol/style/images/widget/icons/warning@2.25x.png \
    apps/costcontrol/style/images/widget/sim/authed-sim@2.25x.png \
    apps/costcontrol/style/images/widget/sim/no-sim@2.25x.png \
    apps/costcontrol/style/images/widget/sim/nonauthed-sim@2.25x.png

You will need the optipng 0.7+ and advancecomp packages installed on your machine for this to work. If you need help feel free to ping me.
Depends on: 990578
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: