984811 - Install button does not change its label after a packaged app is installed

Status: VERIFIED FIXED

(Marketplace Graveyard :: Integration, defect, P1)

Description

[Iulian Timis]

Steps to reproduce:
1. Load Details page for a packaged app on Android (ex. https://marketplace.allizom.org/app/tapout-packed )
2. Tap the "Free" button to install the app

Expected results:
After the app is installed, the install button changes its label to "Launch".

Actual results:
The label for the install button remains "Free" and the user is able to reinstall the app.

Notes/Issues:
Verified on FF 29 Aurora (Android 4.2.1).

Comment 1

[Andy McKay]

Did the app install correctly on the device the first time?

Comment 2

[Iulian Timis]

Yes. I noticed that, after I update the app, the button change its label to "Launch"

Comment 3

[krupa raj[:krupa]]

Iulian,

Do you not see this behavior for hosted apps?

Comment 5

[Iulian Timis]

(In reply to krupa raj[:krupa] from comment #3)
> Iulian,
> 
> Do you not see this behavior for hosted apps?

No, this issue was only reproducing for packaged apps.

Comment 6

[Andy McKay]

This might not be a duplicate then, I'm going to let mstriemer investigate and let us know.

Comment 7

[Mark Striemer [:mstriemer]]

These two bugs are definitely similar but not quite duplicates. The other bug is a mashup of 1) images not loading and 2) the `onerror` callback not being fired when an install is cancelled on Android.

This bug is related because like 2) for the other bug the `onsuccess` callback is never fired for successful installs of packaged apps on Android (hosted apps work fine). I think these are likely different enough to warrant separate platform bugs, I will talk to mhaigh who is working on the other platform bug first though.

Comment 8

[Mark Striemer [:mstriemer]]

Couldn't find mhaigh on IRC so I filed bug 985614.

Comment 9

[Mark Striemer [:mstriemer]]

Also: we are detecting that packaged apps are installed correctly, this issue resolves itself by performing pretty much any action as it triggers re-rendering the button and the install is then detected.

Comment 10

[Cristina Madaras, QA [:CristinaM]]

I can reproduce this issue on Android with Loqui IM app. After install, the "Free" button isn't replace with the "Launch" button and I'm able to reinstall the app.

Device: Galaxy Nexus (Android 4.2.1)
Build: Nightly (2014-05-15)

Comment 11

[Andy McKay]

As far as I can tell this is fixed.

Comment 12

[Iulian Timis]

The button still doesn't change its label to "Launch" and the app can be re-installed. Also, the following error is displayed: "App install error: APK installation canceled by user" after taping on "Done" button on the App installed window. Please see screencast http://screencast.com/t/VXnRGw4jFZX
I have the latest Nightly installed on android 4.2.1 Asus Transformer

Comment 13

[Myk Melez [:myk] [@mykmelez]]

(In reply to Iulian Timis from comment #12)
> The button still doesn't change its label to "Launch" and the app can be
> re-installed. Also, the following error is displayed: "App install error:
> APK installation canceled by user" after taping on "Done" button on the App
> installed window. Please see screencast http://screencast.com/t/VXnRGw4jFZX
> I have the latest Nightly installed on android 4.2.1 Asus Transformer

I don't find "Pills Packed" when I search for it in the marketplace.firefox.com, but I tried installing this Tic-tac-toe app <https://marketplace.firefox.com/app/kolko-i-krzyzyk> and Sketchy <https://marketplace.firefox.com/app/sketchy>, both of which installed successfully, after which the "Free" button changed to a "Launch" button as expected.

I do still see an INVALID_SIGNATURE error in logcat output when attempting to install a packaged app from marketplace-dev.allizom.org, and the button doesn't change its label, nor does the app run when launched.

But that seems like a different issue, and perhaps it isn't a bug in the runtime, as I don't think I've configured my current test device (a Nexus 5 with Android 4.4.3 and the latest nightly build) to install privileged apps from the dev server.

Iulian: can you try installing the apps I mention above from marketplace.firefox.com and let me know if you still see the problem?

Comment 14

[Iulian Timis]

Sorry I forgot to mention, I encountered the issue on MP-stage and having the value of browser.webapps.apkFactoryUrl to https://apk-controller.stage.mozaws.net/application.apk
I have installed a packaged app from production, the button changed its label to "Launch" but I still see the following error after the installation "App install error: APK installation canceled by user"

Comment 15

[Myk Melez [:myk] [@mykmelez]]

(In reply to Iulian Timis from comment #14)
> Sorry I forgot to mention, I encountered the issue on MP-stage and having
> the value of browser.webapps.apkFactoryUrl to
> https://apk-controller.stage.mozaws.net/application.apk

Aha! In that case, you're encountering a different issue.  I'm not sure exactly what it is, but I suspect it's an issue with the certificates used to sign app packages on the staging server, which are presumably different from the certificates used to sign app packages on the production server.  

Does the comma-separated list in the "dom.mozApps.signed_apps_installable_from" pref include the origin of the staging server?  The value of the pref should be something like:

    https://marketplace.firefox.com,https://marketplace.allizom.org

In any case, this is a different issue, so let's track it separately.


> I have installed a packaged app from production, the button changed its
> label to "Launch" but I still see the following error after the installation
> "App install error: APK installation canceled by user"

This too is a different issue, and it's being fixed as a side-effect of the fix for bug 974578.

Comment 16

[Iulian Timis]

Attachment: My Movie.mp4

I can reproduce this issue again in https://marketplace.allizom.org/ on FF33 (Android 4.2.1).
The button label does not change to "Open" after closing the app installation window, it changes only after navigating back to the apps listing page or app details page, or if the page is refreshed.

Comment 17

[Mark Striemer [:mstriemer]]

Does the app install correctly? When I install on stage I get an "INVALID_SIGNATURE" error after install and the button goes back to "Free", reloading shows "Open" as you described. If I install the apps on production however I do not get an error and the button switches to "Launch" right away.

I think this is an error with signing certificates as Myk described above. If you aren't getting a signature error on stage can you please open a new bug as this was originally a platform issue and that appears to be resolved.

Comment 18

[Iulian Timis]

Closing this bug since it was a platform issue.
I have filed Bug 1038130 for the "INVALID_SIGNATURE" error.