984818 - Loop server — List calls should return the name of the caller, not the callee

Status: VERIFIED FIXED

(Hello (Loop) :: Server, defect)

Description

[Alexis Metaireau (:alexis)]

At the moment, when we're doing a GET /calls, we get back a list of pending calls, with an "user" key for each item.

This user key currently is the person that's getting called, and that's pointless: if I'm asking who is calling me, I already know who I am.

We could potentially change that to let the caller specify an userid / name and add this in the database.

Comment 1

[Romain Gauthier [:tOkeshu]]

Attachment: Bug 984818: Listing calls should return the name of the caller

Comment 2

[Alexis Metaireau (:alexis)]

Comment on attachment 8393481 [details] [review]
Bug 984818: Listing calls should return the name of the caller

r+ with the changes natim and I put.

Comment 3

[Rémy Hubscher (:natim)]

Comment on attachment 8393481 [details] [review]
Bug 984818: Listing calls should return the name of the caller

I have added a test for the requireParams middleware.

Comment 4

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8393481 [details] [review]
Bug 984818: Listing calls should return the name of the caller

LGTM

Comment 5

[Rémy Hubscher (:natim)]

- https://github.com/mozilla-services/loop-server/commit/a77d5cd6ed433c80aee684190b228297d6d689e4
- https://github.com/mozilla-services/loop-server/commit/b8aaccfb98a3335ffbea8cc6032281182098e0da

Comment 6

[James Bonacci [:jbonacci]]

Verified in the code.