Closed Bug 984836 Opened 6 years ago Closed 6 years ago

Rename StackFrame to InterpreterFrame

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: jandem, Assigned: jandem)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
The new JITs don't use StackFrame so it'd be nice to rename StackFrame to InterpreterFrame to make this a bit more obvious, especially for people new to SpiderMonkey.
Attachment #8392817 - Flags: review?(luke)
Attached patch PatchSplinter Review
Fix some comments.
Attachment #8392817 - Attachment is obsolete: true
Attachment #8392817 - Flags: review?(luke)
Attachment #8392820 - Flags: review?(luke)
Comment on attachment 8392820 [details] [diff] [review]
Patch

Review of attachment 8392820 [details] [diff] [review]:
-----------------------------------------------------------------

Nice
Attachment #8392820 - Flags: review?(luke) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e91ce9a1eb46

(Green Linux x64 build: https://tbpl.mozilla.org/?tree=Try&rev=7405a13f9fec)

Thanks for the quick review, especially considering GDC etc :)
https://hg.mozilla.org/mozilla-central/rev/e91ce9a1eb46
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.