984872 - Remove deprecated promise.js usage in Firefox for Desktop

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Paolo Amadini]

Attachment: The patch

This patch removes the remaining uses of Add-on SDK Promises in the Firefox for Desktop front-end code.

The only test that needed to be changed was the sanitizer. The production code was logically correct, but the test assumed synchronous processing when clicking the OK button.

Comment 1

[:Paolo Amadini]

Tryserver run: https://tbpl.mozilla.org/?tree=Try&rev=1d7ebc255cff

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8392849 [details] [diff] [review]
The patch

Review of attachment 8392849 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, provided a green Try!

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8392849 [details] [diff] [review]
The patch

>diff --git a/browser/base/content/sanitizeDialog.js b/browser/base/content/sanitizeDialog.js

>-      s.sanitize().then(window.close, window.close);
>+      s.sanitize().then(null, Components.utils.reportError)
>+                  .then(() => window.close())
>+                  .then(null, Components.utils.reportError);

Won't this result in the window staying open if the promise is rejected? That wasn't the intent of the old code...

Comment 4

[Marco Bonardo [:mak]]

(In reply to :Gavin Sharp (email [e-mail]) from comment #3)
> Won't this result in the window staying open if the promise is rejected?
> That wasn't the intent of the old code...

As I read it, if the sanitize promise is rejected it goes reportError, but in any case both success or failure go through window.close(). The third then is to handle window.close exceptions.

Comment 5

[:Paolo Amadini]

https://hg.mozilla.org/integration/fx-team/rev/86f09e63ac6c

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/86f09e63ac6c